From owner-freebsd-net Wed Aug 22 17:35:44 2001 Delivered-To: freebsd-net@freebsd.org Received: from niwun.pair.com (niwun.pair.com [209.68.2.70]) by hub.freebsd.org (Postfix) with SMTP id BC9D937B411 for ; Wed, 22 Aug 2001 17:35:24 -0700 (PDT) (envelope-from silby@silby.com) Received: (qmail 22398 invoked by uid 3193); 23 Aug 2001 00:35:23 -0000 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 23 Aug 2001 00:35:23 -0000 Date: Wed, 22 Aug 2001 20:35:23 -0400 (EDT) From: Mike Silbersack X-Sender: To: Dave Zarzycki Cc: Subject: Re: RFC: SACK/FACK patch port to Current In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Wed, 22 Aug 2001, Dave Zarzycki wrote: > Attached and tested. > > I'd like to merge this in unless anybody objects. > > davez > > -- > Dave Zarzycki I haven't done any testing of this code, but having SACK support would certainly be nice, so I think committing it to -current with the intention of a long testing period before mfcing is a good idea. However, before that is done, I think some changes should be made; all the #ifdef SACK and #ifdef FACKs are ugly. They should be taken out, and runtime tuneables (defaulting to on) should be added around the pieces of code that actually control SACK and FACK initialization at socket setup time. This will ensure that it gets wide testing, and at the same time will allow people who suspect that it is causing problems to still turn it off. Once those changes are made, it's probably best to have 2-3 other committers test and review before committing. Mike "Silby" Silbersack To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message