From owner-freebsd-ports-bugs@freebsd.org Mon Aug 22 10:34:07 2016 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 056A0BC0882 for ; Mon, 22 Aug 2016 10:34:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CF0831431 for ; Mon, 22 Aug 2016 10:34:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u7MAY68g038427 for ; Mon, 22 Aug 2016 10:34:06 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 212004] net/freerdp: Update to 2.0.0.d Date: Mon, 22 Aug 2016 10:34:06 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-patch, needs-qa X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: amdmi3@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Aug 2016 10:34:07 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D212004 --- Comment #15 from Dmitry Marakasov --- Glancing through the patch: - You don't need manual manpage compression, frameworks handles that, so no MANPAGE and no post-install: are needed - PORT_OPTIONS:MGSTREAMER/PORT_OPTIONS:MX11 may be switched to options help= ers, e.g. GSTREAMER_CMAKE_ON, X11_CMAKE_ON (though it also looks to me that the logic in the patch is inversed, e.g. it needs GSTREAMER_CMAKE_ON/X11_CMAKE_OFF). - Since you're using synthetic version number, better go with 2.0.0.a, as 2.0.0.a < 2.0.0 < 2.0.0a - updating from 2.0.0.a to 2.0.0 when it's release won't require a PORTEPOCH bump - Most importantly, since it's major version bump and include path change, = it may and will probably break all dependent ports - these should be checked a= nd bumped. Since this is an unstable version and may affect other ports, please consid= er adding this as another port, e.g. net/freerdp2 or net/freerdp-devel. This w= ill resolve potential compatibility problems, but you'll need some extra hacks = to make two ports coexist - that is, rename conflicting files. It looks that t= hese are only executable files (simple MV in post-patch will do) and libraries (strange that upstream hasn't renamed them while they should've as they have renamed include directoty and pkgconfig files). This is better to be done through CMakeLists.txt modification, as not only .so files need to be renam= ed but SONAME compiled in them changed. --=20 You are receiving this mail because: You are the assignee for the bug.=