From owner-svn-ports-all@freebsd.org Sun Sep 9 12:13:56 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1C54E1093AE6; Sun, 9 Sep 2018 12:13:56 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B3A3371440; Sun, 9 Sep 2018 12:13:55 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from atuin.in.mat.cc (unknown [IPv6:2a01:678:42:ffff:3e15:c2ff:fec4:452e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 12A8F184C7; Sun, 9 Sep 2018 12:13:54 +0000 (UTC) (envelope-from mat@FreeBSD.org) Date: Sun, 9 Sep 2018 14:13:52 +0200 From: Mathieu Arnold To: Yuri Victorovich Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r479271 - head/net/charm Message-ID: <20180909121352.gjas7eutu4xdv44o@atuin.in.mat.cc> References: <201809090641.w896fBv7096222@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="nk2f4kr46akpubwk" Content-Disposition: inline In-Reply-To: <201809090641.w896fBv7096222@repo.freebsd.org> User-Agent: NeoMutt/20180716 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Sep 2018 12:13:56 -0000 --nk2f4kr46akpubwk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Sep 09, 2018 at 06:41:11AM +0000, Yuri Victorovich wrote: > do-fetch: > - @if [ "${FORCE_FETCH_ALL}" =3D "true" ] || ! [ -f "${DISTDIR}/${DIST_SU= BDIR}/${DISTNAME}${EXTRACT_SUFX}" ]; then \ > - ${MKDIR} ${DISTDIR}/${DIST_SUBDIR} && \ > - cd ${DISTDIR}/${DIST_SUBDIR} && \ > - git clone -q ${GIT_URL} ${PORTNAME}-${DISTVERSIONFULL} && \ > - (cd ${PORTNAME}-${DISTVERSIONFULL} && git reset -q --hard ${DISTVER= SIONFULL} && ${RM} -r .git) && \ > - ${FIND} ${PORTNAME}-${DISTVERSIONFULL} -and -exec ${TOUCH} -h -d 19= 70-01-01T00:00:00Z {} \; && \ > - ${FIND} ${PORTNAME}-${DISTVERSIONFULL} -print0 | LC_ALL=3DC ${SORT}= -z | \ > - ${TAR} czf ${PORTNAME}-${DISTVERSIONFULL}${EXTRACT_SUFX} --form= at=3Dbsdtar --uid 0 --gid 0 --options gzip:!timestamp --no-recursion --null= -T - && \ > - ${RM} -r ${PORTNAME}-${DISTVERSIONFULL}; \ > + @if ! [ -f "${DISTDIR}/NAMD_2.12_Source.tar.gz" ]; then \ > + ${ECHO} "(!!)"; \ > + ${ECHO} "(!!) Please download the release tarball of the version 2.12= of NAMD (NAMD_2.12_Source.tar.gz)"; \ > + ${ECHO} "(!!) from https://www.ks.uiuc.edu/Development/Download/downl= oad.cgi?PackageName=3DNAMD,"; \ > + ${ECHO} "(!!) put it into ${DISTDIR}, and run 'make' again."; \ > + ${ECHO} "(!!)"; \ > + ${FALSE}; \ > fi There is a canonical way to do that, inventing a new bad way is really not the thing to do. For some examples on how to do that, please take a look at: audio/festlex-ogi/Makefile biology/phrap/Makefile --=20 Mathieu Arnold --nk2f4kr46akpubwk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAluVDn9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkjYIw//WMOz1Gd5C/bdA84mSWiWc6NZtM3q+OlSjo6HAM/CEvi/Q043ohxQgr0O 8u7mFCRCr1Kfp16dN4ZGZI9Vij3Fqa9a4+YdzmXNK6uuqVZnzV+06GBhPVUgKbP6 jqp3oGbsfJED+zbpKmrc6rGMQX+pAxotsb+wvhdGv47a7Ot6RZgsYG23mHe3Er9n gDs35i7g31IbQ0u43PKSGWWqAjzqmjxvLyxhm5cuNDLZPmElP7RquoLHdaJMZAI9 Zfxq00n5bicTnMIwmDyMwVXgL/n9ahr3queSTQW8jcB6N3gheyA71IfLxrGy8iGf 3n52MAI7HLlcnORKgMmV6KAq1nK7c8UU/YsbskZ03sNvnDr4ivr4+HOEIVDqQILR rarmqea6Tmu3nhMcBipVPImDCH/pIFJovHkIbsezD+UdC9ZkxUjZOOlruxf7jm/2 gOXjyKu/KJLiZF+Ug9ixtEkj2zSlkx4pCSrqXwWkoWNVXx7vM8XfaOI6grPy6QRr gGWVJNFTnE9w7a4/WftqVdO6HGr3mdHJYdg8Oxc/cD+0KgfMKy/psNw4dweyRywp PTl/lUo+4cheZ+Bx4z/QInn/o5Bh7kIE92NUQd0yKWeLq3TWJMrgT+Pzd00HivTG jEOQlwlP5BpBJWMG7RefSJ/h+JSS60QZusjJwfLnQsjfm6Dp2Zg= =7zJM -----END PGP SIGNATURE----- --nk2f4kr46akpubwk--