From owner-freebsd-ports@FreeBSD.ORG Thu Mar 24 06:22:37 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 51FF8106564A; Thu, 24 Mar 2011 06:22:37 +0000 (UTC) (envelope-from avg@freebsd.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 632C68FC13; Thu, 24 Mar 2011 06:22:36 +0000 (UTC) Received: from porto.topspin.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id IAA21776; Thu, 24 Mar 2011 08:22:34 +0200 (EET) (envelope-from avg@freebsd.org) Received: from localhost.topspin.kiev.ua ([127.0.0.1]) by porto.topspin.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1Q2dwI-000HeW-Dn; Thu, 24 Mar 2011 08:22:34 +0200 Message-ID: <4D8AE328.3020906@freebsd.org> Date: Thu, 24 Mar 2011 08:22:32 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.15) Gecko/20110308 Lightning/1.0b2 Thunderbird/3.1.9 MIME-Version: 1.0 To: Baptiste Daroussin X-Enigmail-Version: 1.1.2 Content-Type: multipart/mixed; boundary="------------080605080601010307010902" Cc: freebsd-ports@freebsd.org Subject: libreoffice and gcc44+ X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Mar 2011 06:22:37 -0000 This is a multi-part message in MIME format. --------------080605080601010307010902 Content-Type: text/plain; charset=X-VIET-VPS Content-Transfer-Encoding: 7bit Baptiste, I found it necessary to use the attached patch for libreoffice compilation to succeed with gcc45. (patch name doesn't conform to the ports standards). Without the patch my compilation failed because FILE declaration was not found. I am CC-ing ports@ as this is an example of a classical base gcc vs gcc44+ problem. The reasons for this issue are described here: http://gcc.gnu.org/gcc-4.3/porting_to.html See "Header dependency cleanup". I am surprised that this kind of problem has sneaked into the release code of libreoffice. It could mean two things: (a) they use older gcc themselves; (b) FILE/stdio.h inclusion was brought in by some other inclusion likely in Linux system header files. In any case I think that the upstream developers should have used cstdio header inclusion and std::FILE if they really need that. Are you a regular on their development channels? Maybe you could forward the report to them? Thanks! -- Andriy Gapon --------------080605080601010307010902 Content-Type: text/plain; name="libreoffice-gcc45-includes.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="libreoffice-gcc45-includes.patch" --- build/libreoffice/filter/inc/filter/msfilter/mstoolbar.hxx.orig 2011-03-24 07:57:23.427842820 +0200 +++ build/libreoffice/filter/inc/filter/msfilter/mstoolbar.hxx 2011-03-24 07:59:12.858835904 +0200 @@ -4,6 +4,7 @@ #include "filter/msfilter/msfilterdllapi.h" #include #include +#include #include #include #include --------------080605080601010307010902--