From owner-freebsd-ports@FreeBSD.ORG Thu Nov 5 20:36:14 2009 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CB13D106568D; Thu, 5 Nov 2009 20:36:14 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (lor.one-eyed-alien.net [69.66.77.232]) by mx1.freebsd.org (Postfix) with ESMTP id 581A08FC15; Thu, 5 Nov 2009 20:36:14 +0000 (UTC) Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.14.3/8.14.3) with ESMTP id nA5KYwk7093018; Thu, 5 Nov 2009 14:34:58 -0600 (CST) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.14.3/8.14.3/Submit) id nA5KYwpp093017; Thu, 5 Nov 2009 14:34:58 -0600 (CST) (envelope-from brooks) Date: Thu, 5 Nov 2009 14:34:57 -0600 From: Brooks Davis To: Eitan Adler Message-ID: <20091105203457.GA92771@lor.one-eyed-alien.net> References: <20091104234438.GB42953@lor.one-eyed-alien.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ReaqsoxgOBHFXBhH" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (lor.one-eyed-alien.net [127.0.0.1]); Thu, 05 Nov 2009 14:34:58 -0600 (CST) Cc: ports@freebsd.org, Brooks Davis Subject: Re: using svn to fetch for ports (yet again!) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Nov 2009 20:36:14 -0000 --ReaqsoxgOBHFXBhH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 05, 2009 at 10:17:10PM +0200, Eitan Adler wrote: > > I'd much rather see this used as something that reduced the amount of > > code required for maintainers to build tarballs from SVN. ?For example > > something similar in spirit to what I've done in devel/llvm-devel. ?That > > means mirroring or otherwise transfering the source around is possible. > Would a patch like the one below be what you are looking for? > (Note that I didn't test this patch that much...) Not quite. What I like about overriding do-fetch is that you can do: make -DBOOTSTRAP makesum to both generate the tarball and generate the checksum. You can then go on and build the port like you would otherwise. I also find the auto determination of the latest revision to be very useful. I probably would't include the scp to freefall bit. That's excessivly evil. :) > > There will likely be some objections to putting maintainer functionality > > in bsd.port.mk, but I think it would be useful enough in this case. > > Alternativly we could formalize the process a bit and put something > > Tools/scripts. >=20 > While I have no trouble writing a script to perform these tasks this > is something that I'd like to see available to end users. > I think it would useful to allow users to do something like > SVN_REV=3D1436 make install clean > and thus fetch from svn and install newer/older versions. I think the users would rather build a tarball in that case so they don't have to download everything again when they start tweaking and testing patches. One option might be to set NO_CHECKSUM if the user overrides the revision. You'd need another switch so the maintainer can use makesum in that case, but that should be easy enough. -- Brooks --ReaqsoxgOBHFXBhH Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iD8DBQFK8zbxXY6L6fI4GtQRApxkAJ4tOW/pRuUmwk9MVFXohjl7P54mTQCg0vOc 3h2BLoiPoE427093fIgmeEA= =u3EG -----END PGP SIGNATURE----- --ReaqsoxgOBHFXBhH--