From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Aug 8 10:10:07 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 394041065670 for ; Sat, 8 Aug 2009 10:10:07 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 278688FC2B for ; Sat, 8 Aug 2009 10:10:07 +0000 (UTC) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n78AA7JM037537 for ; Sat, 8 Aug 2009 10:10:07 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n78AA7Fk037536; Sat, 8 Aug 2009 10:10:07 GMT (envelope-from gnats) Date: Sat, 8 Aug 2009 10:10:07 GMT Message-Id: <200908081010.n78AA7Fk037536@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: "b. f." Cc: Subject: Re: ports/137559: [NEW PORT] graphics/mupdf: Lightweight PDF viewer and toolkit X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: "b. f." List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Aug 2009 10:10:07 -0000 The following reply was made to PR ports/137559; it has been noted by GNATS. From: "b. f." To: bug-followup@FreeBSD.org, Martin Dieringer Cc: Subject: Re: ports/137559: [NEW PORT] graphics/mupdf: Lightweight PDF viewer and toolkit Date: Sat, 8 Aug 2009 10:00:28 +0000 Oh, wow: I was just going to do this one. :) Two nits: 1) Please don't hardcode /usr/local in the makefiles. Instead use ${LOCALBASE}. We've been trying to remove errors like this lately. 2) Could you please rename the NOCJK OPTION to CJK, as with other ports, and reverse the logic accordingly? The extra negative in WITH(OUT)_NOCJK is more confusing than WITH(OUT)_CJK. Thanks.