From owner-cvs-src@FreeBSD.ORG Mon Mar 31 16:34:26 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D238E37B401 for ; Mon, 31 Mar 2003 16:34:26 -0800 (PST) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 72C0D43FB1 for ; Mon, 31 Mar 2003 16:34:25 -0800 (PST) (envelope-from nate@rootlabs.com) Received: (qmail 8160 invoked by uid 1000); 1 Apr 2003 00:34:26 -0000 Date: Mon, 31 Mar 2003 16:34:26 -0800 (PST) From: Nate Lawson To: John Baldwin In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_dc.c if_pcn.c if_rl.c if_sf.cif_sis.c if_sk.c if_ste.c if_ti.c if_tl.c if_vr.c if_wb.c if_xl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Apr 2003 00:34:27 -0000 On Mon, 31 Mar 2003, John Baldwin wrote: > On 31-Mar-2003 Nate Lawson wrote: > > On Mon, 31 Mar 2003, Nate Lawson wrote: > >> Modified files: > >> sys/pci if_dc.c if_pcn.c if_rl.c if_sf.c if_sis.c > >> if_sk.c if_ste.c if_ti.c if_tl.c if_vr.c > >> if_wb.c if_xl.c > >> Log: > >> Clean up locking and resource management for pci/if_* > > > > This is a rather large patch so if you begin to experience problems > > attaching or detaching (say on module load/unload) a previously-working > > card, please let me know. > > Already found a bogon in tl(4) when it conflicted with some local > changes. Might want to double check that you don't call detach() > for very early failures when you have no resources to teardown or > release but just do a direct return in the other drivers. There is only one other driver that does anything before the mtx_init (ti(4), ti_mbuf_sanity case) and I handled that correctly. The KASSERT in detach should find any case that detach is called before mtx_init. Thank you for finding this and fixing it. -Nate