From owner-freebsd-bugs@freebsd.org Thu Jan 25 23:10:31 2018 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E983DED4182 for ; Thu, 25 Jan 2018 23:10:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7DCF977042 for ; Thu, 25 Jan 2018 23:10:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id AF77F2AD56 for ; Thu, 25 Jan 2018 23:10:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w0PNATcr029239 for ; Thu, 25 Jan 2018 23:10:29 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w0PNATLR029238 for freebsd-bugs@FreeBSD.org; Thu, 25 Jan 2018 23:10:29 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 225434] [patch] Treat set but empty environment variables as unset in /usr/libexec/phttpget Date: Thu, 25 Jan 2018 23:10:29 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 11.1-STABLE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: cem@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jan 2018 23:10:31 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D225434 --- Comment #3 from Conrad Meyer --- (In reply to Vasil Dimov from comment #2) > Conrad, you got it wrong, just "http_proxy" needs to be set to an empty > string to trigger the bug (with HTTP_PROXY being irrelevant). Did I? The forum link seems to suggest the opposite: > The problem will occur if you set http_proxy variable instead of setting > both HTTP_PROXY and HTTP_PROXY_AUTH. And the code check HTTP_PROXY first. > Because it may contain http_proxy=3D${http_proxy:-""} which is a common i= diom. Citation needed? That line seems wrong for most/all uses. It explicitly replaces unset variable with an empty string version, which causes this who= le mess. By the way, I don't think the user agent portion of the proposed change mak= es sense. An empty string user agent may be desirable, even if non-conformant. --=20 You are receiving this mail because: You are the assignee for the bug.=