From owner-svn-src-all@freebsd.org Sat Nov 18 20:17:21 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B942BDDAFAD; Sat, 18 Nov 2017 20:17:21 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [IPv6:2a01:4f8:c17:6c4b::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 78C9C7B690; Sat, 18 Nov 2017 20:17:21 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2016.home.selasky.org (unknown [62.141.128.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 6B5DF26014D; Sat, 18 Nov 2017 21:17:16 +0100 (CET) Subject: Re: svn commit: r325638 - in head/sys: conf dev/mlx5 dev/mlx5/mlx5_core dev/mlx5/mlx5_en modules/mlx5 To: Konstantin Belousov Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201711100949.vAA9n8Sw008427@repo.freebsd.org> <20171118170235.GJ2272@kib.kiev.ua> From: Hans Petter Selasky Message-ID: Date: Sat, 18 Nov 2017 21:14:29 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171118170235.GJ2272@kib.kiev.ua> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2017 20:17:21 -0000 On 11/18/17 18:02, Konstantin Belousov wrote: > On Fri, Nov 10, 2017 at 09:49:08AM +0000, Hans Petter Selasky wrote: >> Author: hselasky >> Date: Fri Nov 10 09:49:08 2017 >> New Revision: 325638 >> URL: https://svnweb.freebsd.org/changeset/base/325638 >> >> Log: >> Refactor the flowsteering APIs used by mlx5en(4). This change is needed by >> the coming ibcore and mlx5ib updates in order to support traffic redirection >> to so-called raw ethernet QPs. >> >> Remove unused E-switch related routines and files while at it. >> > > This seems to break on all gcc platforms. I see > cc1: warnings being treated as errors > /root/deviant2/sys/dev/mlx5/mlx5_core/mlx5_fs_tree.c:2558: warning: redundant re > declaration of 'iterate_rules_in_ns' [-Wredundant-decls] > /root/deviant2/sys/dev/mlx5/mlx5_core/mlx5_fs_tree.c:2502: warning: previous dec > laration of 'iterate_rules_in_ns' was here > --- mlx5_fs_tree.o --- > *** [mlx5_fs_tree.o] Error code 1 > > > Patch below should fix this item. Are you fine with it ? > > diff --git a/sys/dev/mlx5/mlx5_core/mlx5_fs_tree.c b/sys/dev/mlx5/mlx5_core/mlx5_fs_tree.c > index bf796d65b5f..d0ffa44387c 100644 > --- a/sys/dev/mlx5/mlx5_core/mlx5_fs_tree.c > +++ b/sys/dev/mlx5/mlx5_core/mlx5_fs_tree.c > @@ -2553,10 +2553,6 @@ static void iterate_rules_in_ft(struct mlx5_flow_table *ft, > mutex_unlock(&ft->base.lock); > } > > -static void iterate_rules_in_ns(struct mlx5_flow_namespace *ns, > - rule_event_fn add_rule_cb, > - void *context); > - > static void iterate_rules_in_prio(struct fs_prio *prio, > rule_event_fn add_rule_cb, > void *context) > > No problem. Go ahead. Don't forget to MFC. --HPS