From owner-svn-ports-all@freebsd.org Thu Mar 22 04:20:34 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5F69AF659EF; Thu, 22 Mar 2018 04:20:34 +0000 (UTC) (envelope-from naylor.b.david@gmail.com) Received: from mail-wm0-x229.google.com (mail-wm0-x229.google.com [IPv6:2a00:1450:400c:c09::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C32E97C6CA; Thu, 22 Mar 2018 04:20:33 +0000 (UTC) (envelope-from naylor.b.david@gmail.com) Received: by mail-wm0-x229.google.com with SMTP id t6so13566103wmt.5; Wed, 21 Mar 2018 21:20:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version; bh=Oo369SE4tINDfjyj8eWq2cAfVJi4LJt4Sze1ShIaV9A=; b=ghMD/JkGt6MiMAB/UPmkqD4uRBqfOoLhlFJOOIL99Et5vSuyGRe/v2B7yONymxPygM f9G1T0fdXvsaTYcwKI39nt6/66b3VO7fuk4eYMnInNwZBtChdKEYKcbzYGd8MmQjvCjw NLz9KCN/MzxYh0HIxvTeUAw4pWAzXt8ikoKrOxF9Ska8lbrkAzRFjmwzB26MZXmqc3LR aReiTmlsM8U1z5EHTCvOfQ/3XReaeFDiS7JibB1wYO39rdziMl4/OfphfeF4waHtYkO0 eM7r6yEE3oO8wcG9ung5MOYu5qamGajpvUHDiWoeA0YNf4nf9jvik3BAmtykBKDB+z2W pbaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version; bh=Oo369SE4tINDfjyj8eWq2cAfVJi4LJt4Sze1ShIaV9A=; b=jP9+DYhTPES/c7N9gpbT9FaD5SLi7YavnUod7FtQ+RaAvu9kUamz5ZVJesPG2lTuJH 8PAdkGiF2QyqhjG7nNBdS4SwJMCHoUkyphqHTuVNz634DjR6zFCWUkyrZdKOrpsTx6e7 Jnxh1Tz0YTBqB06wmhCo7kbP0cxf2M/1qvvyuxf7knPkQhMMs2JCRne8MGYSM9fjRq9Z 9Wpk5Ql7pxZt636qFj87h3r1eGRx8WJpCG9VRAwlGvryJAvck9ZFhtVUEz62f67M9mH9 950psV9cgP+UxUHe+kZL6qWhwUgmAyAhAqd1sCG9Mxx1gGdMXqG5SsPqefJLoMjUIyP6 iqmg== X-Gm-Message-State: AElRT7HHr87vZaPaqcjPbKd6QFSAp1LpdibhWFcggRIuHNh1Wqr7QqVG ThAfa7VxBt3troaPcZbu1APPOSTB X-Google-Smtp-Source: AG47ELuS8rgo6EXRMyIPNv2BOs6ZkWRINYrog68Cl4O+r4glOkaxZEao6KJM0E/H9zlwHO96PLFjtA== X-Received: by 10.80.180.169 with SMTP id w38mr19635315edd.305.1521692431667; Wed, 21 Mar 2018 21:20:31 -0700 (PDT) Received: from dragon.local (8ta-148-2-91.telkomadsl.co.za. [41.148.2.91]) by smtp.googlemail.com with ESMTPSA id i7sm4115255edk.7.2018.03.21.21.20.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Mar 2018 21:20:30 -0700 (PDT) From: David Naylor To: Mathieu Arnold Cc: Yuri , Mathieu Arnold , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r464842 - head/devel/py-black Date: Thu, 22 Mar 2018 06:20:27 +0200 Message-ID: <3266631.7f3I6XmlL7@dragon.local> Organization: Private User-Agent: KMail/4.14.10 (FreeBSD/11.1-RELEASE-p4; KDE/4.14.38; amd64; ; ) In-Reply-To: <20180321215019.iai5htaygv3eljtw@atuin.in.mat.cc> References: <201803171854.w2HIsD3u010171@repo.freebsd.org> <20180321215019.iai5htaygv3eljtw@atuin.in.mat.cc> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1597936.b5c6CN2dQY"; micalg="pgp-sha512"; protocol="application/pgp-signature" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Mar 2018 04:20:34 -0000 --nextPart1597936.b5c6CN2dQY Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Wednesday, 21 March 2018 22:50:19 Mathieu Arnold wrote: > On Wed, Mar 21, 2018 at 05:28:19PM +0000, Yuri wrote: > > On 03/20/18 01:12, Mathieu Arnold wrote: > > > This was not a mistake, it was the correct way to do it. Using > > > PY_FLAVOR is more robust because it will always contain the Python > > > flavor. > > > > Should python ports always use @${PY_FLAVOR} then? > > Maybe, I do not know. PY_FLAVOR came late in the flavorization process, > and I did not think much of it at the time. PY_FLAVOR solves an important problem: how do you specify the flavor of a python dependency (especially if the port does not use python flavors, or no flavors). Technically, if the port uses python flavors then PY_FLAVOR=FLAVOR, but the most robust (and consistent way) is to use @${PY_FLAVOR} for dependencies. Regards --nextPart1597936.b5c6CN2dQY Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEElI7FEaJ/AwLnmbU6rWP6jday2lUFAlqzLwtfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk0 OEVDNTExQTI3RjAzMDJFNzk5QjUzQUFENjNGQThERDZCMkRBNTUACgkQrWP6jday 2lVAWhAAtuLniD3GrQ8u7KRewNfkMblF6bQQk5kUjPVQQUQK/r9UbSOlx48P7Y4t bBBFVU4ncbIEGGTV1HRK0jajB0h4sC6wkggS5MgJjX+n3v+OzrR8j9vWdObu8KXq NHK42FItcQhJ9DpEZdYhbLj0qfbDjezwJYmvfSBBgVcJzqNIG2U1P2rv3ADxxhLH k5yNC3tuSe14C5ktYzUpZiVJOz1Z3e6nFFR4kPQLGqsV4prNEw0key5pjmetzAzU awNkIwXR+lBS05evDFfkThM/w6TMvcK9mi/JRWvyttYZs+CBpCOn35BNPYK5csXp kzMet5Yk2dbOBjjB+rLedK+F1cXYEgx6dBHn0+7mLBAS0tOzcJbOvgrudIfBfbyi FKZc0AaqDFwCp5REI7LGOJxBucAETGFBdg4LzOjsAGO77nvMu5gXP+ZjHwvUGPWX qTuTY901qpr/PhDXFcclZ4hcbUD6NK564gVhvVqL+Kl/zCRmtKq321U6cf1jsp3D xIct+O7nNOC1VMtjk+TTJt2xgaidVs10DuFdwsDG8bD1/NXGKAVKpnble8mzTmWX GQoaEfe14WDRJz4Yw2ZmsNccgPqZ8UFRqh8MTJ/+kg6dgT/K5LJL2oxxmd0LXdQS Zz+3Q7AsFL4SpEs2jORzNvWiaLq6m/yurEUyOGopthoBF8xGRNs= =4Ama -----END PGP SIGNATURE----- --nextPart1597936.b5c6CN2dQY--