From owner-svn-ports-all@freebsd.org Thu Oct 25 13:10:49 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B29AA107570C; Thu, 25 Oct 2018 13:10:49 +0000 (UTC) (envelope-from mpp302@gmail.com) Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 58C09812A9; Thu, 25 Oct 2018 13:10:49 +0000 (UTC) (envelope-from mpp302@gmail.com) Received: by mail-qt1-f176.google.com with SMTP id z9-v6so9704799qto.7; Thu, 25 Oct 2018 06:10:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kZEbFJkZklk5wId2jz3HkOnL0yqXu14pG7lsErNUeLc=; b=m4NoO/gtl/8mDtO8PvtBixofMInSWpg9BEvW75H8avDwnJL1SiVcskjuVBdLlodxc2 Kn5mrAbv7jPBkPh3BDQhV2v3wAKAGBVtNe9kWdZeCHJU5SFhRX4degpj7SDz4Gha8LiR 0Bdi2TNIMGNaWpY4rK918aZM+6TDc9zZdwswZXX/pb/qT9Mp6C6yj9zRHaCX0epod19M cQS+QNZVsgNvDaRSB6n6Bmw/YBTYMgo7p05+xMUYaQK80Bh3eYeFstJQlhoUVbp6LQpS 5ptkRqdavjH2iROCd7u6gKBc4az83G/wJ9Clk0m8laUtM8jioNZylgSDEWlr6r9bZkeJ 2pjA== X-Gm-Message-State: AGRZ1gI9lzyu2Qsov9c2zWnK67+8f/4rGaMm/1MTF4OJMBSiaFvM3Wc0 P1slIIZzHgp2wl+rD16Fxlda06Ypfts= X-Google-Smtp-Source: AJdET5fVUyp9AW1lzZZmaX5Z6Qyos4NuAcSwSAfbt3XR4Dhzs9q+oQYP04ALOf6eiotkWnWPtmGdkg== X-Received: by 2002:ac8:4a10:: with SMTP id x16-v6mr1347964qtq.385.1540472609059; Thu, 25 Oct 2018 06:03:29 -0700 (PDT) Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com. [209.85.222.178]) by smtp.gmail.com with ESMTPSA id i35-v6sm4631608qtb.16.2018.10.25.06.03.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Oct 2018 06:03:28 -0700 (PDT) Received: by mail-qk1-f178.google.com with SMTP id r71so1328843qkr.10; Thu, 25 Oct 2018 06:03:28 -0700 (PDT) X-Received: by 2002:a37:5c83:: with SMTP id q125-v6mr1296405qkb.348.1540472608603; Thu, 25 Oct 2018 06:03:28 -0700 (PDT) MIME-Version: 1.0 References: <201810250948.w9P9mGSb099015@repo.freebsd.org> <20181025115917.z2h6zx5txmxkzrtj@ogg.in.absolight.net> In-Reply-To: <20181025115917.z2h6zx5txmxkzrtj@ogg.in.absolight.net> From: Mateusz Piotrowski <0mp@freebsd.org> Date: Thu, 25 Oct 2018 15:03:43 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r482963 - head/misc/exercism To: mat@freebsd.org Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Oct 2018 13:10:49 -0000 Hi, On Thu, 25 Oct 2018 at 13:59, Mathieu Arnold wrote: > On Thu, Oct 25, 2018 at 09:48:16AM +0000, Mateusz Piotrowski wrote: > > - Use DISTVERSION instead of PORTVERSION as suggested by the handbook. > > This should not have happened, the version did not change. > Hmmm, could you please tell me more about this? I thought that it is just a style change because the final value of PORTVERSION has not changed. > > - Move GH_TUPLE out of the USE* section. > > This is wrong, see: > > https://www.freebsd.org/doc/en/books/porters-handbook/porting-order-uses.html Thank you for pointing this out. https://reviews.freebsd.org/D17699 Thanks, Mathieu! Mateusz