Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 3 Dec 2021 11:28:54 GMT
From:      Andriy Gapon <avg@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: b26743df026b - stable/12 - twsi: remove write-only softc field
Message-ID:  <202112031128.1B3BSsGX002485@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/12 has been updated by avg:

URL: https://cgit.FreeBSD.org/src/commit/?id=b26743df026b3c4ce47b6ee17271b84f52147c12

commit b26743df026b3c4ce47b6ee17271b84f52147c12
Author:     Andriy Gapon <avg@FreeBSD.org>
AuthorDate: 2021-11-26 06:45:12 +0000
Commit:     Andriy Gapon <avg@FreeBSD.org>
CommitDate: 2021-12-03 09:35:39 +0000

    twsi: remove write-only softc field
    
    (cherry picked from commit f00bc54f62c455c7ed44afee736c3c64873a305a)
---
 sys/dev/iicbus/twsi/a10_twsi.c | 2 --
 sys/dev/iicbus/twsi/twsi.h     | 1 -
 2 files changed, 3 deletions(-)

diff --git a/sys/dev/iicbus/twsi/a10_twsi.c b/sys/dev/iicbus/twsi/a10_twsi.c
index 17f551f27234..7554db0fbc94 100644
--- a/sys/dev/iicbus/twsi/a10_twsi.c
+++ b/sys/dev/iicbus/twsi/a10_twsi.c
@@ -121,8 +121,6 @@ a10_twsi_attach(device_t dev)
 	sc->reg_baud_rate = TWI_CCR;
 	sc->reg_soft_reset = TWI_SRST;
 
-	sc->need_ack = true;
-
 	if (ofw_bus_is_compatible(dev, "allwinner,sun6i-a31-i2c") ||
 	    ofw_bus_is_compatible(dev, "allwinner,sun6i-a83t-i2c"))
 		sc->iflag_w1c = true;
diff --git a/sys/dev/iicbus/twsi/twsi.h b/sys/dev/iicbus/twsi/twsi.h
index fd107883c07c..fdbd193dbe5b 100644
--- a/sys/dev/iicbus/twsi/twsi.h
+++ b/sys/dev/iicbus/twsi/twsi.h
@@ -65,7 +65,6 @@ struct twsi_softc {
 	int			transfer;
 	int			error;
 	uint32_t		control_val;
-	bool			need_ack;
 	bool			iflag_w1c;
 
 	bus_size_t	reg_data;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202112031128.1B3BSsGX002485>