Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 26 Aug 2022 16:38:47 +0000
From:      bugzilla-noreply@freebsd.org
To:        bugs@FreeBSD.org
Subject:   [Bug 265974] SMR has several missing barriers
Message-ID:  <bug-265974-227-My0FHkj2z8@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-265974-227@https.bugs.freebsd.org/bugzilla/>
References:  <bug-265974-227@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D265974

--- Comment #5 from Mark Johnston <markj@FreeBSD.org> ---
(In reply to Konstantin Belousov from comment #3)
> That said, atomic_add_acq on x86 has the sequentially consistent semantic
already (which is why you said that it works on Intel, right?).  So the
#ifdef from the patch in smr_enter() is not needed, use seq_cst fence
for all arches.

The ifdef makes some sense as an optimization.  On x86 we can combine the s=
tore
and barrier into one instruction, so why not do that?

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-265974-227-My0FHkj2z8>