From nobody Wed Mar 25 16:27:03 2026 X-Original-To: pkgbase@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fgskR4Q5mz6WTf2; Wed, 25 Mar 2026 16:27:11 +0000 (UTC) (envelope-from ziaee@FreeBSD.org) Received: from mailtransmit04.runbox.com (mailtransmit04.runbox.com [IPv6:2a0c:5a00:149::25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4fgskR2DXkz3Mcw; Wed, 25 Mar 2026 16:27:11 +0000 (UTC) (envelope-from ziaee@FreeBSD.org) Authentication-Results: mx1.freebsd.org; none Received: from mailtransmit02.runbox ([10.9.9.162] helo=aibo.runbox.com) by mailtransmit04.runbox.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1w5R4R-005J9b-RU; Wed, 25 Mar 2026 17:27:03 +0100 Received: from [10.9.9.127] (helo=rmmprod05.runbox) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1w5R4R-0000hD-BE; Wed, 25 Mar 2026 17:27:03 +0100 Received: from mail by rmmprod05.runbox with local (Exim 4.86_2) (envelope-from ) id 1w5R4R-0001pm-9C; Wed, 25 Mar 2026 17:27:03 +0100 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable List-Id: Packaging the FreeBSD base system List-Archive: https://lists.freebsd.org/archives/freebsd-pkgbase List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-pkgbase@FreeBSD.org MIME-Version: 1.0 Received: from [Authenticated alias (960477)] by runbox.com with http (RMM6); Wed, 25 Mar 2026 16:27:03 GMT From: "Alexander Ziaee" To: "Pete Wright" , "Lexi Winter" CC: "hackers" , "pkgbase" Subject: Re: more pkgbase reviewers required Date: Wed, 25 Mar 2026 16:27:03 +0000 (UTC) X-RMM-Aliasid: 960477 X-Mailer: RMM6 In-Reply-To: <7B32EC96-7D56-41B1-940F-DE3C84DE08E9@nomadlogic.org> Message-Id: X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:50304, ipnet:2a0c:5a00::/29, country:NO] X-Rspamd-Queue-Id: 4fgskR2DXkz3Mcw X-Spamd-Bar: ---- On 2026-03-25 11:13 -04:00 EDT, "Pete Wright" wrote: >=20 >> On Mar 25, 2026, at 7:52=E2=80=AFAM, Lexi Winter wrote: >>=20 >> =EF=BB=BFPete Wright wrote in <3536ba2d-ada0-4ebe-8e20-da94c9bc6fea@noma= dlogic.org>: >>>> On 3/25/26 05:54, Lexi Winter wrote: >>>> at this point, it's extremely difficult to get any pkgbase-related >>>> changes reviewed in Phabricator, which is an issue since we're now >>>> pushing pkgbase as the default method for installing the system. >>>> [...] >>>=20 >>> do you need to have a commit bit to be a useful reviewer. >>=20 >> no. although... i will say i tend to give more attention to reviews >> from other committers. but it's not a requirement to be a committer >> to review a change, and it's very helpful to get feedback from testing >> (e.g., "this change broke my system!"), or to know that a particular >> change might break existing deployments, for example. >>=20 >> but when considering whether to land a change, i only look at reviews >> from committers. i.e., i might *not* land a change if non-committers >> have objections, but i will not land a change if the only reviews are >> from non-committers. >>=20 >> does that make sense? basically what i'm saying is, yes, it's useful >> to get feedback on changes from people who aren't committers, but we >> still need committers to actually land changes. >=20 > Understood - I=E2=80=99ll let yall with commit bits do your thing and get= out of the way since it sounds like it=E2=80=99ll just be noise. No, it's not noise. Community reviews are extremely helpful. What I believe= ivy is saying is that her specific ask in this thread is that more committ= ers review to satisfy the goal that we have a consensus about changes. We need all the testing and constructive feedback we can get. Best, Alex=