From owner-freebsd-current@FreeBSD.ORG Tue Nov 25 10:08:52 2008 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C6EA8106564A; Tue, 25 Nov 2008 10:08:52 +0000 (UTC) (envelope-from rink@rink.nu) Received: from mx1.rink.nu (gloom.rink.nu [213.34.49.2]) by mx1.freebsd.org (Postfix) with ESMTP id 8642E8FC17; Tue, 25 Nov 2008 10:08:52 +0000 (UTC) (envelope-from rink@rink.nu) Received: from localhost (localhost [127.0.0.1]) by mx1.rink.nu (Postfix) with ESMTP id 89EA56D439; Tue, 25 Nov 2008 11:09:21 +0100 (CET) X-Virus-Scanned: amavisd-new at rink.nu Received: from mx1.rink.nu ([213.34.49.2]) by localhost (gloom.rink.nu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rptyavxwzC0u; Tue, 25 Nov 2008 11:09:18 +0100 (CET) Received: by mx1.rink.nu (Postfix, from userid 1000) id 419406D42B; Tue, 25 Nov 2008 11:09:18 +0100 (CET) Date: Tue, 25 Nov 2008 11:09:18 +0100 From: Rink Springer To: Luigi Rizzo Message-ID: <20081125100918.GB64854@rink.nu> References: <20081125094125.GA18669@onelab2.iet.unipi.it> <20081125094635.GA64854@rink.nu> <20081125100243.GA19436@onelab2.iet.unipi.it> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081125100243.GA19436@onelab2.iet.unipi.it> User-Agent: Mutt/1.5.18 (2008-05-17) Cc: Rink Springer , current@freebsd.org Subject: Re: small newfs_msdos addition X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Nov 2008 10:08:52 -0000 On Tue, Nov 25, 2008 at 11:02:43AM +0100, Luigi Rizzo wrote: > Right now it does this: > > > newfs_msdos /tmp/aaa > newfs_msdos: warning: /tmp/aaa is not a character device > /tmp/aaa: 20424 sectors in 2553 FAT12 clusters (4096 bytes/cluster) > bps=512 spc=8 res=1 nft=2 rde=512 sec=20480 mid=0xf0 spf=8 spt=64 hds=32 hid=0 > > so the warning is there already. > I am a bit reluctant to add one more option -- the whole goal was to > make it easy to use, otherwise one could just exploit the existing flags. Yes, that makes sense. > > When I create a md(4), I may have accidently forgotten to specify the > > geometry and I would like to be reminded that it made something up, > > well, the whole geometry thing (and disktab) is a relic of the past. > These days it is completley meaningless -- hard disks always have a fake > geometry (63sec/255heads), same for flash memories... Well, I vaguely recall problems when trying to boot from FAT12 filesystems for use on bootable CD's where the geometry was off... However, this was quite a long time ago so my memory may be lapsing. I think this change makes sense, especially since it will always inform you of what it did. I'd say it's OK to commit. Regards, -- Rink P.W. Springer - http://rink.nu "Anyway boys, this is America. Just because you get more votes doesn't mean you win." - Fox Mulder