From owner-svn-src-all@freebsd.org  Sun Nov 22 22:02:33 2020
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id F20EA47687E;
 Sun, 22 Nov 2020 22:02:33 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: from smtp.freebsd.org (smtp.freebsd.org
 [IPv6:2610:1c1:1:606c::24b:4])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4CfPQx6YNFz4X4q;
 Sun, 22 Nov 2020 22:02:33 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com
 [209.85.222.174])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK))
 (Authenticated sender: kevans)
 by smtp.freebsd.org (Postfix) with ESMTPSA id D36048EDA;
 Sun, 22 Nov 2020 22:02:33 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: by mail-qk1-f174.google.com with SMTP id d28so14874984qka.11;
 Sun, 22 Nov 2020 14:02:33 -0800 (PST)
X-Gm-Message-State: AOAM532Rj4bASDCse/TwB990eA9Y6g5qnWIhGFblte12+RU7tY3W1FmK
 rUfftKyVXssho9Y/u/7AKiuv6Frn78cuPVtLC2w=
X-Google-Smtp-Source: ABdhPJy3TLNMtMnQM4IwHu9qwxRG6PZlWYHK7o3jsQTsrsJfvKfD3Iwm54uGVSc6Tn0poiB4k/8On6yaLjRG+3eTcrg=
X-Received: by 2002:a05:620a:12ea:: with SMTP id
 f10mr11929904qkl.430.1606082553551; 
 Sun, 22 Nov 2020 14:02:33 -0800 (PST)
MIME-Version: 1.0
References: <202011220534.0AM5Yp4u071733@repo.freebsd.org>
 <X7oZcKwB7FZ1j7fo@kib.kiev.ua>
In-Reply-To: <X7oZcKwB7FZ1j7fo@kib.kiev.ua>
From: Kyle Evans <kevans@freebsd.org>
Date: Sun, 22 Nov 2020 16:02:22 -0600
X-Gmail-Original-Message-ID: <CACNAnaGKdSLgMUJwb0HwGgHXJgJ-qe5ng9gV62MmxyssS7rCSQ@mail.gmail.com>
Message-ID: <CACNAnaGKdSLgMUJwb0HwGgHXJgJ-qe5ng9gV62MmxyssS7rCSQ@mail.gmail.com>
Subject: Re: svn commit: r367928 - in head/sys: compat/freebsd32 kern sys
To: Konstantin Belousov <kostikbel@gmail.com>
Cc: src-committers <src-committers@freebsd.org>,
 svn-src-all <svn-src-all@freebsd.org>, 
 svn-src-head <svn-src-head@freebsd.org>
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 22 Nov 2020 22:02:34 -0000

On Sun, Nov 22, 2020 at 1:55 AM Konstantin Belousov <kostikbel@gmail.com> wrote:
>
> On Sun, Nov 22, 2020 at 05:34:51AM +0000, Kyle Evans wrote:
> > Author: kevans
> > Date: Sun Nov 22 05:34:51 2020
> > New Revision: 367928
> > URL: https://svnweb.freebsd.org/changeset/base/367928
> >
> > Log:
> >   _umtx_op: move compat32 definitions back in
> >
> >   These are reasonably compact, and a future commit will blur the compat32
> >   lines by supporting 32-bit operations with the native _umtx_op.
>
> I do not mind much about placement of the compat32 syscall stubs, but I
> did suggested and liked move of the compat32 structures definitions into
> freebsd32.h.
>
> They are actually useful that way, at least allowing me to write some (private)
> tests in the past.

Ah, sure, sorry- this doesn't force us to re-add implementation
details to other headers, so I don't see any problem. I will move just
the struct definitions back shortly.