From owner-freebsd-hackers@FreeBSD.ORG Tue Oct 26 13:46:04 2010 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7AD67106572D; Tue, 26 Oct 2010 13:46:04 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 4B2C88FC13; Tue, 26 Oct 2010 13:46:04 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 879AA46B46; Tue, 26 Oct 2010 09:46:03 -0400 (EDT) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 71D7D8A01D; Tue, 26 Oct 2010 09:46:02 -0400 (EDT) From: John Baldwin To: freebsd-hackers@freebsd.org Date: Tue, 26 Oct 2010 09:31:36 -0400 User-Agent: KMail/1.13.5 (FreeBSD/7.3-CBSD-20100819; KDE/4.4.5; amd64; ; ) References: <4CC6830A.10701@icyb.net.ua> In-Reply-To: <4CC6830A.10701@icyb.net.ua> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201010260931.36342.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Tue, 26 Oct 2010 09:46:02 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.96.3 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-1.9 required=4.2 tests=BAYES_00 autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on bigwig.baldwin.cx Cc: Konstantin Belousov , Andriy Gapon , Selphie Keller Subject: Re: SYSCALL_MODULE() macro and modfind() issues X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Oct 2010 13:46:04 -0000 On Tuesday, October 26, 2010 3:28:10 am Andriy Gapon wrote: > on 26/10/2010 01:01 Selphie Keller said the following: > > hi fbsd-hackers, > > > > Noticed a issue in 8.1-release, 8.1p1-release and 8.1-stable > > amd64/i386, to where modfind() will no longer find pmap_helper for the > > /usr/ports/sysutils/pmap port, or other syscall modules using > > SYSCALL_MODULE() macro. > > The issue is that modfind() function no longer finds any modules using > > SYSCALL_MODULE() macro to register the kernel module. Making it > > difficult for userland apps to call the syscall provided. modfind() > > always returns -1 which prevents modstat() from getting the required > > information to perform the syscall. > > > > Also tested, the demo syscall module: > > After commit r205320 and, apparently, its MFC you need to prefix the module with > "sys/". For example: > modstat(modfind("sys/syscall"), &stat); > > P.S. > Perhaps a KPI breakage in a stable branch? Ugh, it was a breakage though it's too late to back it out at this point. -- John Baldwin