From owner-cvs-all Mon Jun 10 0:15:33 2002 Delivered-To: cvs-all@freebsd.org Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by hub.freebsd.org (Postfix) with ESMTP id 238F037B400; Mon, 10 Jun 2002 00:15:29 -0700 (PDT) Received: by elvis.mu.org (Postfix, from userid 1192) id EF6F0AE162; Mon, 10 Jun 2002 00:15:28 -0700 (PDT) Date: Mon, 10 Jun 2002 00:15:28 -0700 From: Alfred Perlstein To: Alan Cox Cc: Alan Cox , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/vm vm_map.c Message-ID: <20020610071528.GJ88163@elvis.mu.org> References: <200206100611.g5A6BkG16910@freefall.freebsd.org> <20020610061849.GI88163@elvis.mu.org> <20020610071411.GL17003@cs.rice.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020610071411.GL17003@cs.rice.edu> User-Agent: Mutt/1.3.27i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * Alan Cox [020610 00:14] wrote: > On Sun, Jun 09, 2002 at 11:18:49PM -0700, Alfred Perlstein wrote: > > * Alan Cox [020609 23:12] wrote: > > > Log: > > > o In vm_map_entry_create(), call uma_zalloc() with M_NOWAIT on system maps. > > > > Are you sure that is correct? Shouldn't we just propogate the WAIT > > flag down from the higher level allocation rather than _always_ > > doing a NOWAIT allocation? > > > > Yes, as sure as I (and Tor) can be. Allocation of map entries > for system maps should never be allowed to block. This is not > a new rule. Prior to the UMA conversion, we had: > > zinitna(kmapentzone, &kmapentobj, > NULL, 0, cnt.v_page_count / 4, ZONE_INTERRUPT, 1); makes sense, thank you. :) -- -Alfred Perlstein [alfred@freebsd.org] To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message