From owner-freebsd-bugs@FreeBSD.ORG  Wed Nov  5 13:08:10 2014
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id F0DFE6AD
 for <freebsd-bugs@FreeBSD.org>; Wed,  5 Nov 2014 13:08:10 +0000 (UTC)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id D87356D6
 for <freebsd-bugs@FreeBSD.org>; Wed,  5 Nov 2014 13:08:10 +0000 (UTC)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id sA5D8ApD025653
 for <freebsd-bugs@FreeBSD.org>; Wed, 5 Nov 2014 13:08:10 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 194204] getentropy(2): sys call from openbsd
Date: Wed, 05 Nov 2014 13:08:11 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: 11.0-CURRENT
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: mjg@FreeBSD.org
X-Bugzilla-Status: Needs Triage
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-194204-8-h8P32WEi4B@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-194204-8@https.bugs.freebsd.org/bugzilla/>
References: <bug-194204-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Nov 2014 13:08:11 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=194204

Mateusz Guzik <mjg@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mjg@FreeBSD.org

--- Comment #2 from Mateusz Guzik <mjg@FreeBSD.org> ---
I'm confused with this patch.

OpenBSD implementation returns EIO for too big buffers, although apparently
this was not the behaviour from the start. Previously it filled up to 256
bytes, but also indicated how many bytes were returned.

Your patch fills up to 256 bytes and does not tell the caller how many bytes it
got, which is a big no-no.

We should stick to what is in OpenBSD, so please update the patch to return EIO
when needed.

memset you put there is buggy. explicit_zero or equivalent is needed and if we
don't have that in the kernel one will need to be ported as well.

Cannot comment on arc4rand usefulness for this purpose though.

-- 
You are receiving this mail because:
You are the assignee for the bug.