Date: Thu, 4 Oct 2018 17:06:57 +0300 From: Gleb Popov <arrowd@freebsd.org> To: bapt@freebsd.org Cc: Alexey Dokuchaev <danfe@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r481210 - head/lang/ghc Message-ID: <CALH631nF7A2rgOppApB%2BsZnG749DphF%2BdOUN-m3acBN4c--=pQ@mail.gmail.com> In-Reply-To: <20181004122221.rz5b2qlp6xqucjbu@ivaldir.net> References: <201810040834.w948Y9SE084351@repo.freebsd.org> <20181004090206.GA73328@FreeBSD.org> <CALH631=UzDL0huHHG=Y=WVHgcSNyLtRqBX5b%2Bvko7zoDNAEvZw@mail.gmail.com> <20181004122221.rz5b2qlp6xqucjbu@ivaldir.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Oct 4, 2018 at 3:22 PM Baptiste Daroussin <bapt@freebsd.org> wrote: > On Thu, Oct 04, 2018 at 01:14:02PM +0300, Gleb Popov wrote: > > On Thu, Oct 4, 2018 at 12:02 PM Alexey Dokuchaev <danfe@freebsd.org> > wrote: > > > > > On Thu, Oct 04, 2018 at 08:34:09AM +0000, Gleb Popov wrote: > > > > New Revision: 481210 > > > > URL: https://svnweb.freebsd.org/changeset/ports/481210 > > > > > > > > Log: > > > > lang/ghc: Remove BOOTH option. > > > > > > This is very bad commit message. Please always try to exlain the > changes > > > made, not simply translate the diff into English. Your mentor should > have > > > told you that. > > > > > > ./danfe > > > > > > > An explanation in the Phab Diff isn't sufficient? > > > No the explaination should be first in the commit logs which is what we > all face > at first > > Bapt > Ok, taken into account.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CALH631nF7A2rgOppApB%2BsZnG749DphF%2BdOUN-m3acBN4c--=pQ>