From nobody Fri Sep 22 21:51:15 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RsmDg5tNsz4tTTb; Fri, 22 Sep 2023 21:51:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RsmDg5KfCz3Pn1; Fri, 22 Sep 2023 21:51:15 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695419475; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=th5PKB5TrPorJY26yIo9IVyZjeboZojKEFP/30jUl1A=; b=bfWSz1HYt/zxFAvcblwehjbzhu2yKJ0QE71l5wBORMGE2zDkcFy/GoIWDGY/s4UxVrJEsD yVwK0MEqacpb2xvM98ZzqyL2gSoSuCn6plxL3t9H6ffHRPuM5BOfpdM5vO1pRKTE0YVL4C q38em+kuDNcJjFjZ4dJ/6zxeGaz5I19QOROE1FAHF5WhQOnTuKYzq41yNCeAa9fAlvg3it 5dXtgmtdVplW+iRtsZGmR7dRSoEMPkwEdCCE5YQkQMUs+WosEGN270S2xYwA5nHlBp/5ty p1/0EFF4M9EsuXiNhz/Yjp77bGTJRkLyTbGNJyeSC9T48e+VZWh0XRMJ9Ac7hg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1695419475; a=rsa-sha256; cv=none; b=AOBp0QKByByb1XyseLhTgzkEFuNRhJkJHTgndxyxgNOlZRkJHG9+YEoXuoPj4P7w7bRvXh /SDtkMohK2J/i3S1cm/H+TXjgAFhJN382df3hIQXN9Q1fwR+bDBnwMM0+uBPWEDpfYv3// ud9DaaRLYJ73QNJlF1YVT5IO+YxVkfuIJ/328HpA7w9B+BzdlvRJ/zTpjn1oZfy67PLLAb 8ltGxAk+fULmVHQp01/62y+Oodn6faaxg+oOIxkrhfBBShGUJIyflT379wVrHZkd3TawAy amvdCfoCEe7Ltk899GX2t0qnf/Y7Qcd0PSmyEopbR4UUsSJ+PRSRQi65jt2OdQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695419475; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=th5PKB5TrPorJY26yIo9IVyZjeboZojKEFP/30jUl1A=; b=PDC/6cWA1OV5ogzUhXs64V5nkhjVik2t/s3m6r+mBMmI1Wun7CGuNbGY+LjxVC8Jidfzhb G0NWL+1yjtnR7Muu0RYFGnq3VeqgjdzDEvz6AHIYqwDn/vDrrNpxEyB1KdLjtFwPA/WZX9 Q2SdYvekqT5CXesD/jISSRrbtrHwAlf5vtktre5cO6ehWod/5aUgyOjgcBANKXSua3fPHx lwIRPjZ6l8uAuUjJFZ/tYgMXAPlvpLGfPJU1O9HuwzmY8qt03WZYGVmySOtvh1784xte7g 0GJJDWbUUk5Kkr9VHnwOia9VXVOPkbNNRBKaPnWhId5QjknpQZEAtqI5GQzUyQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RsmDg4RYQzdvH; Fri, 22 Sep 2023 21:51:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 38MLpFPa039255; Fri, 22 Sep 2023 21:51:15 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 38MLpF2p039252; Fri, 22 Sep 2023 21:51:15 GMT (envelope-from git) Date: Fri, 22 Sep 2023 21:51:15 GMT Message-Id: <202309222151.38MLpF2p039252@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mateusz Guzik Subject: git: 2ea531b264df - stable/14 - vfs: don't kick vnlru if it is already running List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mjg X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 2ea531b264df97bfea7d74c7f9414b2d3c5d4277 Auto-Submitted: auto-generated The branch stable/14 has been updated by mjg: URL: https://cgit.FreeBSD.org/src/commit/?id=2ea531b264df97bfea7d74c7f9414b2d3c5d4277 commit 2ea531b264df97bfea7d74c7f9414b2d3c5d4277 Author: Mateusz Guzik AuthorDate: 2023-09-14 16:27:47 +0000 Commit: Mateusz Guzik CommitDate: 2023-09-22 21:50:46 +0000 vfs: don't kick vnlru if it is already running Further shaves some lock trips. (cherry picked from commit 76f1153790b6d2e1a4f0389c3ac24e41d08f9ba6) --- sys/kern/vfs_subr.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sys/kern/vfs_subr.c b/sys/kern/vfs_subr.c index 80ec15f78028..4c9cb6200f10 100644 --- a/sys/kern/vfs_subr.c +++ b/sys/kern/vfs_subr.c @@ -1557,9 +1557,11 @@ vnlru_kick_locked(void) } static void -vnlru_kick(void) +vnlru_kick_cond(void) { + if (vnlruproc_sig) + return; mtx_lock(&vnode_list_mtx); vnlru_kick_locked(); mtx_unlock(&vnode_list_mtx); @@ -1812,7 +1814,7 @@ alloc: mtx_assert(&vnode_list_mtx, MA_NOTOWNED); rnumvnodes = atomic_fetchadd_long(&numvnodes, 1) + 1; if (vnlru_under(rnumvnodes, vlowat)) - vnlru_kick(); + vnlru_kick_cond(); return (uma_zalloc_smr(vnode_zone, M_WAITOK)); }