From owner-freebsd-commit Thu Oct 12 06:43:45 1995 Return-Path: owner-commit Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id GAA12578 for freebsd-commit-outgoing; Thu, 12 Oct 1995 06:43:45 -0700 Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id GAA12458 for cvs-all-outgoing; Thu, 12 Oct 1995 06:43:19 -0700 Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id GAA12430 for cvs-sys-outgoing; Thu, 12 Oct 1995 06:43:15 -0700 Received: from hda.com (hda.com [199.232.40.182]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id GAA12388 ; Thu, 12 Oct 1995 06:43:09 -0700 Received: (from dufault@localhost) by hda.com (8.6.11/8.6.9) id FAA02078; Thu, 12 Oct 1995 05:45:11 -0400 From: Peter Dufault Message-Id: <199510120945.FAA02078@hda.com> Subject: Re: cvs commit: src/sys/scsi sd.c st.c To: julian@freefall.freebsd.org (Julian Elischer) Date: Thu, 12 Oct 1995 05:45:10 -0400 (EDT) Cc: CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org In-Reply-To: <199510120202.TAA28012@freefall.freebsd.org> from "Julian Elischer" at Oct 11, 95 07:02:06 pm X-Mailer: ELM [version 2.4 PL24] Content-Type: text Content-Length: 753 Sender: owner-commit@FreeBSD.org Precedence: bulk > > julian 95/10/11 19:02:06 > > Modified: sys/scsi sd.c st.c > Log: > Ack! > sometime around 1.51, the check for minphys dissappeared out of > transfers for disks.. > we weren't hecking that the adapter could handle a transfer of > the size we were requesting.. > Peter!? > :) (Yeah, change scsi_read and scsi_write. Next time I'll look at the source before responding.) The SCSI drivers use rawread and rawrite, which go through scsi_strategy and so should be calling scsi_minphys. There may be a bug, but IMHO you addressed it in the wrong place. -- Peter Dufault Real Time Machine Control and Simulation HD Associates, Inc. Voice: 508 433 6936 dufault@hda.com Fax: 508 433 5267