From owner-freebsd-bugs  Fri Oct 24 00:00:07 1997
Return-Path: <owner-freebsd-bugs>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.7/8.8.7) id AAA28349
          for bugs-outgoing; Fri, 24 Oct 1997 00:00:07 -0700 (PDT)
          (envelope-from owner-freebsd-bugs)
Received: (from gnats@localhost)
          by hub.freebsd.org (8.8.7/8.8.7) id AAA28336;
          Fri, 24 Oct 1997 00:00:03 -0700 (PDT)
          (envelope-from gnats)
Resent-Date: Fri, 24 Oct 1997 00:00:03 -0700 (PDT)
Resent-Message-Id: <199710240700.AAA28336@hub.freebsd.org>
Resent-From: gnats (GNATS Management)
Resent-To: freebsd-bugs
Resent-Reply-To: FreeBSD-gnats@FreeBSD.ORG, pangolin@rogers.wave.ca
Received: from pc-21490.bc.rogers.wave.ca (pc-21490.bc.rogers.wave.ca [24.113.51.240])
          by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id XAA27963
          for <FreeBSD-gnats-submit@freebsd.org>; Thu, 23 Oct 1997 23:53:00 -0700 (PDT)
          (envelope-from jh@pc-21490.bc.rogers.wave.ca)
Received: (from jh@localhost)
	by pc-21490.bc.rogers.wave.ca (8.8.7/8.8.7) id XAA01041;
	Thu, 23 Oct 1997 23:52:28 -0700 (PDT)
Message-Id: <199710240652.XAA01041@pc-21490.bc.rogers.wave.ca>
Date: Thu, 23 Oct 1997 23:52:28 -0700 (PDT)
From: pangolin@rogers.wave.ca
Reply-To: pangolin@rogers.wave.ca
To: FreeBSD-gnats-submit@FreeBSD.ORG
X-Send-Pr-Version: 3.2
Subject: bin/4840: fsck dumps core when it can't read super block
Sender: owner-freebsd-bugs@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk


>Number:         4840
>Category:       bin
>Synopsis:       fsck dumps core when it can't read super block
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Oct 24 00:00:01 PDT 1997
>Last-Modified:
>Originator:     Jonathan Hanna
>Organization:
>Release:        FreeBSD 3.0-CURRENT i386
>Environment:

FreeBSD 3.0-CURRENT
FreeBSD 2.2-STABLE is OK

>Description:

fsck in 3.0-CURRENT dumps core after dereferencing an unitialized
super block data structure. It seems the setup() routine now returns more
than a boolean. That is handled by a case statement with a suspicious
fall through.

>How-To-Repeat:

#
# as non-root
#
bash-2.01$ fsck
Can't open /dev/rwd1a: Permission denied
Segmentation fault (core dumped)

>Fix:

Possible patch. I do not know what the purpose of the fall through is.
Exit code meaning is also unknown.

--- main.c.orig Thu Oct 23 23:14:50 1997
+++ main.c      Thu Oct 23 23:23:12 1997
@@ -195,7 +195,8 @@
        case 0:
                if (preen)
                        pfatal("CAN'T CHECK FILE SYSTEM.");
-               /* fall through */
+               /* don't fall through */
+               return(1);
        case -1:
                pwarn("clean, %ld free ", sblock.fs_cstotal.cs_nffree +
                        sblock.fs_frag * sblock.fs_cstotal.cs_nbfree);

>Audit-Trail:
>Unformatted: