From owner-freebsd-net Thu Aug 16 23:22:59 2001 Delivered-To: freebsd-net@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id 47AA537B434 for ; Thu, 16 Aug 2001 23:22:52 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id QAA21174; Fri, 17 Aug 2001 16:22:46 +1000 Date: Fri, 17 Aug 2001 16:22:44 +1000 (EST) From: Bruce Evans X-X-Sender: To: Julian Elischer Cc: Subject: Re: IPV6/KAME/protosw integration cleanup In-Reply-To: Message-ID: <20010817161114.S34202-100000@besplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Thu, 16 Aug 2001, Julian Elischer wrote: > On Thu, 16 Aug 2001, Bruce Evans wrote: > > > > I will not be doing any changes that affect them, Though I may still add > > > the prototype definitions in protsw.h as that's a generally useful thing > > > to do. > > > > I think those are the least useful of your changes. They are certainly > > the most intrusive if the function typedefs are actually used. > > yes but the rest of them have been argued against by the KAME folk > and I have agreed to let them do it.. > (which changes in specific terms, are you refering to?) Function typedefs. > The good thing about the typedefs is that > if you change them, then you automatically change all teh prototypes that > use them, So there is no benefit if no prototypes use them. > which means that when you compile, you get failures on all teh > functions that mismatch their prototypes which means that you HAVE to fix > all the mismatching functions. Without them you just get warning messages > on the structure initialisations, which you can easily miss, or ignore.. They aren't easy to miss :-). You see them once every time you build a kernel with them configured. I think it's just a gcc "feature" that mismatches in initializers are only warnings. Warnings for initializers can be suppressed using casts. That is really evil (worse than varargs :-) but we do it for syscalls and vops. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message