From owner-cvs-all  Mon Jul  5 10:12:28 1999
Delivered-To: cvs-all@freebsd.org
Received: from apollo.backplane.com (apollo.backplane.com [209.157.86.2])
	by hub.freebsd.org (Postfix) with ESMTP
	id 0614E15173; Mon,  5 Jul 1999 10:12:19 -0700 (PDT)
	(envelope-from dillon@apollo.backplane.com)
Received: (from dillon@localhost)
	by apollo.backplane.com (8.9.3/8.9.1) id KAA77491;
	Mon, 5 Jul 1999 10:12:12 -0700 (PDT)
	(envelope-from dillon)
Date: Mon, 5 Jul 1999 10:12:12 -0700 (PDT)
From: Matthew Dillon <dillon@apollo.backplane.com>
Message-Id: <199907051712.KAA77491@apollo.backplane.com>
To: David Greenman <dg@root.com>
Cc: Stephen McKay <syssgm@detir.qld.gov.au>,
	Kirk McKusick <mckusick@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG,
	cvs-all@FreeBSD.ORG
Subject: Re: cvs commit: src/sys/i386/i386 machdep.c src/sys/kern vfs_bio.c vfs_subr.c src/sys/sys buf.h kernel.h proc.h src/sys/vm vm_pageout.c vm_pager.c 
References:  <199907051120.EAA02790@implode.root.com>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

    looks fine to me, too.

					-Matt
					Matthew Dillon 
					<dillon@backplane.com>

:
:   Looks good - please commit.
:
:-DG
:
:David Greenman
:Co-founder/Principal Architect, The FreeBSD Project - http://www.freebsd.org
:Creator of high-performance Internet servers - http://www.terasolutions.com
:
:>On Saturday, 3rd July 1999, Kirk McKusick wrote:
:>
:>>  A small race condition was fixed in getpbuf() in vm/vm_pager.c.
:>
:>That's one butt ugly goto!  Here is my suggested (untested) reformatting:
:>
:>
:>Index: vm_pager.c
:>===================================================================
:>RCS file: /cvs/src/sys/vm/vm_pager.c,v
:>retrieving revision 1.50
:>diff -u -c -r1.50 vm_pager.c
:>*** vm_pager.c	1999/07/04 00:25:38	1.50
:>--- vm_pager.c	1999/07/05 10:50:41
:>***************
:>*** 377,394 ****
:>  
:>  	s = splvm();
:>  
:>! retry:
:...
:>  
:>! 	for (;;) {
:>! 		if (pfreecnt) {
:...



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message