From owner-cvs-src@FreeBSD.ORG Tue Jun 14 01:14:41 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 67E3216A41C; Tue, 14 Jun 2005 01:14:41 +0000 (GMT) (envelope-from jeff@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4735243D48; Tue, 14 Jun 2005 01:14:41 +0000 (GMT) (envelope-from jeff@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j5E1EfiE041233; Tue, 14 Jun 2005 01:14:41 GMT (envelope-from jeff@repoman.freebsd.org) Received: (from jeff@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j5E1Efri041232; Tue, 14 Jun 2005 01:14:41 GMT (envelope-from jeff) Message-Id: <200506140114.j5E1Efri041232@repoman.freebsd.org> From: Jeff Roberson Date: Tue, 14 Jun 2005 01:14:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern vfs_syscalls.c vfs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jun 2005 01:14:41 -0000 jeff 2005-06-14 01:14:40 UTC FreeBSD src repository Modified files: sys/kern vfs_syscalls.c vfs_vnops.c Log: - Remove vnode lock asserts at the end of vfs syscalls. These asserts were used to ensure that we weren't exiting the syscall with a lock still held. This wasn't safe, however, because we'd already executed a vput() and on a loaded system the vnode may have been free'd by the time we assert. This functionality is also handled by the td_locks assert in userret, which doesn't tell you what the syscall was, but will at least panic before you deadlock. Sponsored by: Isilon Systems, Inc. Discovred by: Peter Holm Approved by: re (blanket vfs) Revision Changes Path 1.391 +0 -18 src/sys/kern/vfs_syscalls.c 1.233 +0 -2 src/sys/kern/vfs_vnops.c