From owner-svn-ports-head@FreeBSD.ORG  Thu Dec 20 22:44:23 2012
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id B7EFA2D2;
 Thu, 20 Dec 2012 22:44:23 +0000 (UTC)
 (envelope-from gerald@pfeifer.com)
Received: from ainaz.pair.com (ainaz.pair.com [209.68.2.66])
 by mx1.freebsd.org (Postfix) with ESMTP id 4E1688FC12;
 Thu, 20 Dec 2012 22:44:23 +0000 (UTC)
Received: from [192.168.0.10] (199.244.3.202.dsl.dyn.mana.pf [202.3.244.199])
 by ainaz.pair.com (Postfix) with ESMTPSA id 9E6963F427;
 Thu, 20 Dec 2012 17:44:10 -0500 (EST)
Date: Thu, 20 Dec 2012 23:44:04 +0100 (CET)
From: Gerald Pfeifer <gerald@pfeifer.com>
To: Oliver Lehmann <oliver@freebsd.org>, Eitan Adler <eadler@freebsd.org>
Subject: Re: svn commit: r309264 - head/security/oidentd
In-Reply-To: <CAF6rxgkSe6W3wQT49rrbVMxyrQOkgVw2bcv8r_4=P2xfWBiKTw@mail.gmail.com>
Message-ID: <alpine.LNX.2.00.1212202335360.2358@tuna.site>
References: <201212192025.qBJKPMJ6078702@svn.freebsd.org>
 <CAF6rxgkSe6W3wQT49rrbVMxyrQOkgVw2bcv8r_4=P2xfWBiKTw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Dec 2012 22:44:23 -0000

On Wed, 19 Dec 2012, Eitan Adler wrote:
> On 19 December 2012 15:25, Oliver Lehmann <oliver@freebsd.org> wrote:
>> +CONFIGURE_ENV+=        CFLAGS="${CFLAGS} -std=gnu89"
> 
> Why not
> 
> USE_CSTD=gnu89 ?

First and foremost: why add CFLAGS="${CFLAGS}" to CONFIGURE_ENV?

Mk/bsd.port.mk already has the following:

   if ! ${SETENV} CC="${CC}" CPP="${CPP}" CXX="${CXX}" \
   CFLAGS="${CFLAGS}" CPPFLAGS="${CPPFLAGS}" CXXFLAGS="${CXXFLAGS}" \
   :
   ${CONFIGURE_ENV} ./${CONFIGURE_SCRIPT} ${CONFIGURE_ARGS}; then \
        ${ECHO_MSG} "===>  Script \"${CONFIGURE_SCRIPT}\" failed unexpectedly."; \

And portlint warns about it as well:

   WARN: Makefile: [34]: use a tab (not space) after a variable name
   WARN: Makefile: CFLAGS/CXXFLAGS are not needed in CONFIGURE_ENV as they are already added there in bsd.port.mk.

Can you please fix those two?

Gerald