From owner-freebsd-bugs  Thu Jun  8 19:17:32 1995
Return-Path: bugs-owner
Received: (from majordom@localhost)
          by freefall.cdrom.com (8.6.10/8.6.6) id TAA06070
          for bugs-outgoing; Thu, 8 Jun 1995 19:17:32 -0700
Received: from blob.best.net (blob.best.net [204.156.128.88])
          by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id TAA06062
          for <bugs@freebsd.org>; Thu, 8 Jun 1995 19:17:28 -0700
Received: from shell1.best.com (shell1.best.com [204.156.128.10]) by blob.best.net (8.6.12/8.6.5) with ESMTP id TAA04917 for <bugs@freebsd.org>; Thu, 8 Jun 1995 19:16:29 -0700
Received: (dillon@localhost) by shell1.best.com (8.6.12/8.6.5) id TAA13416; Thu, 8 Jun 1995 19:16:58 -0701
Date: Thu, 8 Jun 1995 19:16:58 -0701
From: Matt Dillon <dillon@best.com>
Message-Id: <199506090217.TAA13416@shell1.best.com>
To: bugs@FreeBSD.org
Subject: connect() bug found and fixed (uninitialized pointer)
Sender: bugs-owner@FreeBSD.org
Precedence: bulk

    In case Dima didn't get this off to you, there's a bug in
    netinet/tcp_usrreq.c: tcp_connect()... the ifaddr is left
    uninitialized in the case where in_pcbladdr() fails.  The fix
    is to check the error code from in_pcbladdr() and to return
    it rather then fall through to the remaining code if it comes
    back non-zero.

    I stuck a printf() in there to catch the condition as well just to
    see how often it occured... got about a hit every 10 minutes
    on our (very busy) FTP/WWW server from ftpd.

    Gotta quick question for you guys too:  Is it safe to create
    UFS partitions greater then 2GB ?

					-Matt

    Matthew Dillon   VP Engineering, BEST Internet Communications, Inc.
		    <dillon@best.com>, <dillon@apollo.west.oic.com>
    [always include a portion of the original email in any response!]