Date: Fri, 15 Nov 2013 08:44:15 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Adam Weinberger <adamw@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r333807 - head/textproc/multimarkdown Message-ID: <20131115074415.GO56153@ithaqua.etoilebsd.net> In-Reply-To: <201311142331.rAENVAQK039370@svn.freebsd.org> References: <201311142331.rAENVAQK039370@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Vy1A5eXR7jld12ZH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 14, 2013 at 11:31:10PM +0000, Adam Weinberger wrote: > Author: adamw > Date: Thu Nov 14 23:31:09 2013 > New Revision: 333807 > URL: http://svnweb.freebsd.org/changeset/ports/333807 >=20 > Log: > Add an include-able file to facilitate checking out sources from git. > Useful especially for projects that don't have distfiles, or that use > submodules that don't have distfiles. >=20 Hi, This port is full of issues with the ports tree and breaks lot of principle= of the ports tree. 1/ it depends on the https interface of github, meaning you need git compil= ed with the CURL option, which not every body activates 2/ it has no distinfo to validate the distfiles so we have to garanty 2 peo= ple building multimarkdown are building the same thing! if upstream does 2 new commits then git tag -d <tag1> and git tag <tag1> th= en you are doomed without noticing. 3/ all distfiles should be individually fetchable and storable. We need to be able to have offline builders, and for them we need to be abl= e to feed them with distfiles by putting them into the distfiles directory of the offline builder, this method totally kills that. 4/ it is using submodules meaning the revision of the bundle code is not kn= own meaning that any single packages can potentially be bundling different code untested by the maintainer. Somone should teach upstream how to make a release or we should not provide packages for them. The right way to handle this imho would be to properly use USE_GITHUB by fetching the distfiles related to the commit/tag multimarkdown depends on Then fetch the same way the distfiles of the submodules. in post-extract move the content of the submodules into the final directory. That should build. I know you ask for advice on this, sorry I haven't find time to help earlie= r. regards, Bapt --Vy1A5eXR7jld12ZH Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlKF0M4ACgkQ8kTtMUmk6EyEQQCeIzjrSwWcGPnEIR/uliKQh54Q wWUAniibFphjbedQ9nsN7A6llb7+tuNM =Mmpc -----END PGP SIGNATURE----- --Vy1A5eXR7jld12ZH--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131115074415.GO56153>