From owner-freebsd-audit  Sat Mar  2 10:47:29 2002
Delivered-To: freebsd-audit@freebsd.org
Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42])
	by hub.freebsd.org (Postfix) with ESMTP
	id E6FC037B400; Sat,  2 Mar 2002 10:47:26 -0800 (PST)
Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1])
	by nagual.pp.ru (8.12.2/8.12.2) with ESMTP id g22Il2Yl032322;
	Sat, 2 Mar 2002 21:47:19 +0300 (MSK)
	(envelope-from ache@pobrecita.freebsd.ru)
Received: (from ache@localhost)
	by pobrecita.freebsd.ru (8.12.2/8.12.2/Submit) id g22Ikxmq032321;
	Sat, 2 Mar 2002 21:47:00 +0300 (MSK)
Date: Sat, 2 Mar 2002 21:46:57 +0300
From: "Andrey A. Chernov" <ache@nagual.pp.ru>
To: Alexey Zelkin <phantom@FreeBSD.org>
Cc: audit@FreeBSD.org
Subject: Re: safety checking for catgets (NLS catalogs)
Message-ID: <20020302184656.GA32218@nagual.pp.ru>
References: <20020302202437.A1078@gate.sim.ionidea.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20020302202437.A1078@gate.sim.ionidea.com>
User-Agent: Mutt/1.3.27i
Sender: owner-freebsd-audit@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-audit.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-audit>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-audit>
X-Loop: FreeBSD.ORG

I dislike whole idea, it just add yet one runtime slowness. Suser programs
authors should just check their translations more accurately.

Better way to solve it is to add external check tool to run through all
existen catalogs for given program, do it once and not each run time.

Translation strings are per program version constants and not changed each
run time, so there is absolutely no needs to check them each run time.

On Sat, Mar 02, 2002 at 20:24:37 +0200, Alexey Zelkin wrote:

> +    while (*src != '\0' && *dflt != '\0') {
> +	while (1) {
> +	    if (*dflt != *src)
> +		return (1);
> +	    if (strchr(VALID_CONV_SPECIFIERS, *dflt))

*dflt can be '\0' here and strchr() will succeed.

> +		break;
> +	    src++;
> +	    dflt++;
> +	}

-- 
Andrey A. Chernov
http://ache.pp.ru/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message