From owner-svn-src-all@freebsd.org  Sun Feb  7 16:48:07 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 45232AA07FA;
 Sun,  7 Feb 2016 16:48:07 +0000 (UTC)
 (envelope-from brde@optusnet.com.au)
Received: from mail109.syd.optusnet.com.au (mail109.syd.optusnet.com.au
 [211.29.132.80])
 by mx1.freebsd.org (Postfix) with ESMTP id 0DDB51A14;
 Sun,  7 Feb 2016 16:48:06 +0000 (UTC)
 (envelope-from brde@optusnet.com.au)
Received: from c110-21-41-193.carlnfd1.nsw.optusnet.com.au
 (c110-21-41-193.carlnfd1.nsw.optusnet.com.au [110.21.41.193])
 by mail109.syd.optusnet.com.au (Postfix) with ESMTPS id 7C1EED6656B;
 Mon,  8 Feb 2016 03:47:58 +1100 (AEDT)
Date: Mon, 8 Feb 2016 03:47:57 +1100 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@besplex.bde.org
To: Pedro Giffuni <pfg@freebsd.org>
cc: src-committers@freebsd.org, svn-src-all@freebsd.org, 
 svn-src-head@freebsd.org
Subject: Re: svn commit: r295362 - head/sys/fs/cd9660
In-Reply-To: <56B76ABA.8000607@FreeBSD.org>
Message-ID: <20160208034651.X3197@besplex.bde.org>
References: <201602070348.u173meT4000314@repo.freebsd.org>
 <20160207175356.A867@besplex.bde.org> <56B76ABA.8000607@FreeBSD.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Optus-CM-Score: 0
X-Optus-CM-Analysis: v=2.1 cv=R4L+YolX c=1 sm=1 tr=0
 a=73JWPhLeruqQCjN69UNZtQ==:117 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10
 a=s5jvgZ67dGcA:10 a=kj9zAlcOel0A:10 a=vXAd-1f9--jQ1isoXEQA:9
 a=CjuIK1q_8ugA:10
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 07 Feb 2016 16:48:07 -0000

On Sun, 7 Feb 2016, Pedro Giffuni wrote:

> On 02/07/16 02:13, Bruce Evans wrote:
>> On Sun, 7 Feb 2016, Pedro F. Giffuni wrote:
>> 
>>> Log:
>>>  cd9660: Drop an unnecessary check for NULL.
>>> 
>>>  This was unnecessary and also confused Coverity.
>>> 
>>>  Confirmed on:    NetBSD
>>>  CID:        978558
>> 
>> This leaves many similar bugs unfixed nearby.  One is a null pointer
>> panic, not just an unnecessary check.
>
> I admittedly oversimplified the commit log here.
>
> Not only the value can't be null, our brelse() also ignores NULL values.
>
> From sys/kern/vfs_bio.c:
> ____
> 	/*
> 	 * Many function erroneously call brelse with a NULL bp under rare
> 	 * error conditions. Simply return when called with a NULL bp.
> 	 */
> 	if (bp == NULL)
> 		return;
> ...
> ____

It has only done that for 11 days.

Bruce