From owner-cvs-all Mon Nov 26 9:38:36 2001 Delivered-To: cvs-all@freebsd.org Received: from panzer.kdm.org (panzer.kdm.org [216.160.178.169]) by hub.freebsd.org (Postfix) with ESMTP id 363B337B416; Mon, 26 Nov 2001 09:38:32 -0800 (PST) Received: (from ken@localhost) by panzer.kdm.org (8.11.6/8.9.1) id fAQHcOg03609; Mon, 26 Nov 2001 10:38:24 -0700 (MST) (envelope-from ken) Date: Mon, 26 Nov 2001 10:38:23 -0700 From: "Kenneth D. Merry" To: "Justin T. Gibbs" Cc: Ian Dowse , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/cam/scsi scsi_da.c Message-ID: <20011126103823.A3595@panzer.kdm.org> References: <200111261638.aa78493@salmon.maths.tcd.ie> <200111261641.fAQGfVY45664@aslan.scsiguy.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2i In-Reply-To: <200111261641.fAQGfVY45664@aslan.scsiguy.com>; from gibbs@scsiguy.com on Mon, Nov 26, 2001 at 09:41:31AM -0700 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, Nov 26, 2001 at 09:41:31 -0700, Justin T. Gibbs wrote: > >>If you look in the PR, the controller properly reports that the > >>sync cache command is unsupported. Quirks should only be used > >>for devices that catastrophically fail when a sync cache command > >>is sent. This also gives us the oportunity to *fix* whatever is > >>wrong with the code in the da driver that should silenty accept > >>a properly rejected sync cache command. I've looked at the code > > > >Sorry, I must have missed your message in the audit-trail for that > >PR where you say basically the same thing. The PR is quite old; > >maybe the problem has been fixed since? > > > >Anyway, I'll back out that change and ask the submitter for > >more information. Are there any other devices you're aware > >of that exibit this behaviour which I might be able to try? > > I would say that perhaps 75% or more of our sync cache quirk > entries fall into this category. Very few devices catastrophically > fail. I don't recall off-hand which entries I've complained about > in the past. Perhaps Ken will remember. I don't remember which entries specifically were just reporting problems, but I'd agree that most of them are reporting problems and not a device that blows up when it sees a cache sync. Ken -- Kenneth Merry ken@kdm.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message