From owner-freebsd-ports@FreeBSD.ORG  Tue Mar 24 20:26:19 2015
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 1D512DB2
 for <freebsd-ports@freebsd.org>; Tue, 24 Mar 2015 20:26:19 +0000 (UTC)
Received: from ziemba.us (osmtp.ziemba.us [208.106.105.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id D96D719B
 for <freebsd-ports@freebsd.org>; Tue, 24 Mar 2015 20:26:18 +0000 (UTC)
Received: from hairball.ziemba.us (localhost.ziemba.us [127.0.0.1])
 by hairball.ziemba.us (8.14.9/8.14.9) with ESMTP id t2OKJ15h097850
 for <freebsd-ports@freebsd.org>; Tue, 24 Mar 2015 13:19:01 -0700 (PDT)
 (envelope-from pz-freebsd-ports@ziemba.us)
Received: (from mailnull@localhost)
 by hairball.ziemba.us (8.14.9/8.14.9/Submit) id t2OKIw8I097827
 for freebsd-ports@freebsd.org; Tue, 24 Mar 2015 13:18:58 -0700 (PDT)
 (envelope-from pz-freebsd-ports@ziemba.us)
X-Authentication-Warning: hairball.ziemba.us: mailnull set sender to
 pz-freebsd-ports@ziemba.us using -f
Received: (from news@localhost)
 by usenet.ziemba.us (8.14.5/8.14.5/Submit) id t2OKIwv9059221
 for treehouse-mail-freebsd-ports@hairball.ziemba.us;
 Tue, 24 Mar 2015 13:18:58 -0700 (PDT) (envelope-from news)
From: "G. Paul Ziemba" <pz-freebsd-ports@ziemba.us>
To: freebsd-ports@freebsd.org
Subject: Re: patch to bsd.ports.mk to support out-of-tree patches.
Date: Tue, 24 Mar 2015 20:18:58 +0000 (UTC)
Message-id: <mesgri$1pqk$1@usenet.ziemba.us>
References: <5510F71B.7030900@freebsd.org>
 <20150324113240.Horde._MOpnfwGcxQa7v8pi_ozUQ2@webmail.df.eu>
Reply-to: paul+usenet@w6yx.stanford.edu
Errors-to: "G. Paul Ziemba" <paul+usenet@w6yx.stanford.edu>
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports/>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Mar 2015 20:26:19 -0000

mva@freebsd.org (Marcus von Appen) writes:

>Julian Elischer <julian@freebsd.org>:

>[...]
>>          esac | ${PATCH} ${PATCH_DIST_ARGS} `patch_dist_strip $$i` ; \
>>      done )
>>  .endif
>> +.if defined(EXTRA_PATCH_TREE)
>[...]
>> +.endif
>>  .if defined(EXTRA_PATCHES)
>>      @set -e ; \
>>      for i in ${EXTRA_PATCHES}; do \
>>
>>
>> ============

>Nice. I'd however change the patch behaviour to the following:

>- patch-* from FreeBSD
>- EXTRA_PATCHES from FreeBSD
>- local patches

>Your patch looks like it appleis the out-of-tree patches prior
>to any EXTRA_PATCHES defined by the port itself. This should not be
>the case, in my opinion. Locally managed patches should always come
>last to ensure that all FreeBSD/maintainer-specific bits have been
>applied and the local changes are just added on top of those.

Julian and others, I am wholly in favor of this capability. I have
been using a similar bsd.port.mk patch for some years based on
the discussions in this thread:
http://lists.freebsd.org/pipermail/freebsd-ports/2008-December/051767.html

I also agree with Marcus above regarding the order of application of patches.

Looking forward to its inclusion in the ports tree.
-- 
G. Paul Ziemba
FreeBSD unix:
 1:16PM  up 13 days, 12:51, 5 users, load averages: 1.36, 1.08, 0.97