From owner-freebsd-threads@FreeBSD.ORG  Thu Sep 21 07:24:13 2006
Return-Path: <owner-freebsd-threads@FreeBSD.ORG>
X-Original-To: freebsd-threads@FreeBSD.org
Delivered-To: freebsd-threads@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E984D16A407;
	Thu, 21 Sep 2006 07:24:13 +0000 (UTC) (envelope-from anders@fupp.net)
Received: from fupp.net (totem.fix.no [80.91.36.20])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7711543D46;
	Thu, 21 Sep 2006 07:24:11 +0000 (GMT) (envelope-from anders@fupp.net)
Received: from localhost (totem.fix.no [80.91.36.20])
	by fupp.net (Postfix) with ESMTP id A67978D98A1;
	Thu, 21 Sep 2006 09:24:09 +0200 (CEST)
Received: from fupp.net ([80.91.36.20])
	by localhost (totem.fix.no [80.91.36.20]) (amavisd-new,
	port 10024) with LMTP
	id 53839-01-6; Thu, 21 Sep 2006 09:24:09 +0200 (CEST)
Received: by fupp.net (Postfix, from userid 1000)
	id 53FF48D989E; Thu, 21 Sep 2006 09:24:09 +0200 (CEST)
Date: Thu, 21 Sep 2006 09:24:09 +0200
From: Anders Nordby <anders@fupp.net>
To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-threads@FreeBSD.org,
	Thomas-Martin Seck <tmseck@netcologne.de>,
	Suleiman Souhlal <ssouhlal@FreeBSD.org>
Message-ID: <20060921072409.GA53487@totem.fix.no>
References: <20060911075431.D12758D9874@fupp.net>
	<200609110800.k8B80ie3041853@freefall.freebsd.org>
	<20060912195547.GA71462@totem.fix.no>
	<20060913185803.GA27955@totem.fix.no>
	<20060916205908.GG9421@funkthat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20060916205908.GG9421@funkthat.com>
X-PGP-Key: http://anders.fix.no/pgp/
X-PGP-Key-FingerPrint: 1E0F C53C D8DF 6A8F EAAD  19C5 D12A BC9F 0083 5956
User-Agent: Mutt/1.5.11
Cc: 
Subject: Re: threads/103127: Kernel panic while using thread features in
	Squid 2.6
X-BeenThere: freebsd-threads@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Threading on FreeBSD <freebsd-threads.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>, 
	<mailto:freebsd-threads-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-threads>
List-Post: <mailto:freebsd-threads@freebsd.org>
List-Help: <mailto:freebsd-threads-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>,
	<mailto:freebsd-threads-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Sep 2006 07:24:14 -0000

Hi,

On Sat, Sep 16, 2006 at 01:59:08PM -0700, John-Mark Gurney wrote:
> Please try the attached patch.. It appears that the badfo_kqfilter was
> returning sucess instead of error since it was introcuded many years
> ago...  This many still cause other problems w/ squid, but will fix
> the panics...
> --- kern_descrip.c	21 Jul 2006 20:24:00 -0000	1.297
> +++ kern_descrip.c	16 Sep 2006 20:58:40 -0000
> @@ -2632,7 +2632,7 @@
>  badfo_kqfilter(struct file *fp, struct knote *kn)
>  {
>  
> -	return (0);
> +	return (EINVAL);
>  }
>  
>  static int

This patch fixes the kernel panics that I have reported about in this
PR. I have 9 cache servers with Squid2.6 that had this problem. After
patching them, one by one, they haven't had any panics anymore.

Cheers,

-- 
Anders.