Date: Mon, 7 Feb 2011 17:18:30 -0800 (PST) From: PseudoCylon <moonlightakkiy@yahoo.ca> To: Bernhard Schmidt <bschmidt@freebsd.org> Cc: freebsd-net@freebsd.org, Alexander Zagrebin <alex@zagrebin.ru> Subject: Re: if_run in hostap mode: issue with stations in the power save mode Message-ID: <95679.17379.qm@web39320.mail.mud.yahoo.com> In-Reply-To: <201102061142.43865.bschmidt@freebsd.org> References: <20110204060808.GA97298@gw.zagrebin.ru> <201102041314.17939.bschmidt@freebsd.org> <147585.89029.qm@web39304.mail.mud.yahoo.com> <201102061142.43865.bschmidt@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--0-1961750709-1297127910=:17379 Content-Type: text/plain; charset=us-ascii ----- Original Message ---- > From: Bernhard Schmidt <bschmidt@freebsd.org> > To: PseudoCylon <moonlightakkiy@yahoo.ca> > Cc: Alexander Zagrebin <alex@zagrebin.ru>; freebsd-net@freebsd.org > Sent: Sun, February 6, 2011 3:42:43 AM > Subject: Re: if_run in hostap mode: issue with stations in the power save mode Afaik iwn(4) doesn't use PS, never got around implementing that. > > > I'd like to move ieee80211_beacon_alloc() into iv_vap_alloc(). Then > > we don't need to test beacon_mbuf == NULL in run_update_beacon_cb(), > > and there is already switch we can use for conditionally alloc mem. > > Sounds fine with we. > Oops, there is switch before malloc vap. the test is still in run_update_beacon_cb() > Can I talk you into integrating that into Alexander's patch? > The patch is attached. (diff to HEAD) Bit long, just because there is a couple of new call back functions to avoid LOR. AK --0-1961750709-1297127910=:17379 Content-Type: application/octet-stream; name="run.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="run.patch" ZGlmZiAtLWdpdCBhL2Rldi91c2Ivd2xhbi9pZl9ydW4uYyBiL2Rldi91c2Iv d2xhbi9pZl9ydW4uYwppbmRleCBkZjcyZjcyLi4xY2QxNTkxIDEwMDY0NAot LS0gYS9kZXYvdXNiL3dsYW4vaWZfcnVuLmMKKysrIGIvZGV2L3VzYi93bGFu L2lmX3J1bi5jCkBAIC0zODgsNiArMzg4LDcgQEAgc3RhdGljIHZvaWQJcnVu X3NjYW5fZW5kKHN0cnVjdCBpZWVlODAyMTFjb20gKik7CiBzdGF0aWMgdm9p ZAlydW5fdXBkYXRlX2JlYWNvbihzdHJ1Y3QgaWVlZTgwMjExdmFwICosIGlu dCk7CiBzdGF0aWMgdm9pZAlydW5fdXBkYXRlX2JlYWNvbl9jYih2b2lkICop Owogc3RhdGljIHZvaWQJcnVuX3VwZGF0ZXByb3Qoc3RydWN0IGllZWU4MDIx MWNvbSAqKTsKK3N0YXRpYyB2b2lkCXJ1bl91cGRhdGVwcm90X2NiKHZvaWQg Kik7CiBzdGF0aWMgdm9pZAlydW5fdXNiX3RpbWVvdXRfY2Iodm9pZCAqKTsK IHN0YXRpYyB2b2lkCXJ1bl9yZXNldF9saXZlbG9jayhzdHJ1Y3QgcnVuX3Nv ZnRjICopOwogc3RhdGljIHZvaWQJcnVuX2VuYWJsZV90c2Zfc3luYyhzdHJ1 Y3QgcnVuX3NvZnRjICopOwpAQCAtMzk4LDYgKzM5OSw3IEBAIHN0YXRpYyB2 b2lkCXJ1bl9zZXRfbGVkcyhzdHJ1Y3QgcnVuX3NvZnRjICosIHVpbnQxNl90 KTsKIHN0YXRpYyB2b2lkCXJ1bl9zZXRfYnNzaWQoc3RydWN0IHJ1bl9zb2Z0 YyAqLCBjb25zdCB1aW50OF90ICopOwogc3RhdGljIHZvaWQJcnVuX3NldF9t YWNhZGRyKHN0cnVjdCBydW5fc29mdGMgKiwgY29uc3QgdWludDhfdCAqKTsK IHN0YXRpYyB2b2lkCXJ1bl91cGRhdGVzbG90KHN0cnVjdCBpZm5ldCAqKTsK K3N0YXRpYyB2b2lkCXJ1bl91cGRhdGVzbG90X2NiKHZvaWQgKik7CiBzdGF0 aWMgdm9pZAlydW5fdXBkYXRlX21jYXN0KHN0cnVjdCBpZm5ldCAqKTsKIHN0 YXRpYyBpbnQ4X3QJcnVuX3Jzc2kyZGJtKHN0cnVjdCBydW5fc29mdGMgKiwg dWludDhfdCwgdWludDhfdCk7CiBzdGF0aWMgdm9pZAlydW5fdXBkYXRlX3By b21pc2NfbG9ja2VkKHN0cnVjdCBpZm5ldCAqKTsKQEAgLTY3NCw3ICs2NzYs NyBAQCBydW5fYXR0YWNoKGRldmljZV90IHNlbGYpCiAJaWMtPmljX3NldF9j aGFubmVsID0gcnVuX3NldF9jaGFubmVsOwogCWljLT5pY19ub2RlX2FsbG9j ID0gcnVuX25vZGVfYWxsb2M7CiAJaWMtPmljX25ld2Fzc29jID0gcnVuX25l d2Fzc29jOwotCS8vaWMtPmljX3VwZGF0ZXNsb3QgPSBydW5fdXBkYXRlc2xv dDsKKwlpYy0+aWNfdXBkYXRlc2xvdCA9IHJ1bl91cGRhdGVzbG90OwogCWlj LT5pY191cGRhdGVfbWNhc3QgPSBydW5fdXBkYXRlX21jYXN0OwogCWljLT5p Y193bWUud21lX3VwZGF0ZSA9IHJ1bl93bWVfdXBkYXRlOwogCWljLT5pY19y YXdfeG1pdCA9IHJ1bl9yYXdfeG1pdDsKQEAgLTg1Niw2ICs4NTgsOCBAQCBy dW5fdmFwX2RlbGV0ZShzdHJ1Y3QgaWVlZTgwMjExdmFwICp2YXApCiAKIAlS VU5fTE9DSyhzYyk7CiAKKwltX2ZyZWVtKHJ2cC0+YmVhY29uX21idWYpOwor CiAJcnZwX2lkID0gcnZwLT5ydnBfaWQ7CiAJc2MtPnJhdGVjdGxfcnVuICY9 IH4oMSA8PCBydnBfaWQpOwogCXNjLT5ydnBfYm1hcCAmPSB+KDEgPDwgcnZw X2lkKTsKQEAgLTM5MDEsOCArMzkwNSwyOSBAQCBydW5fdXBkYXRlX2JlYWNv bihzdHJ1Y3QgaWVlZTgwMjExdmFwICp2YXAsIGludCBpdGVtKQogewogCXN0 cnVjdCBpZWVlODAyMTFjb20gKmljID0gdmFwLT5pdl9pYzsKIAlzdHJ1Y3Qg cnVuX3NvZnRjICpzYyA9IGljLT5pY19pZnAtPmlmX3NvZnRjOworCXN0cnVj dCBydW5fdmFwICpydnAgPSBSVU5fVkFQKHZhcCk7CisJaW50IG1jYXN0ID0g MDsKIAl1aW50MzJfdCBpOwogCisJS0FTU0VSVCh2YXAgIT0gTlVMTCwgKCJu byBiZWFjb24iKSk7CisKKwlzd2l0Y2ggKGl0ZW0pIHsKKwljYXNlIElFRUU4 MDIxMV9CRUFDT05fRVJQOgorCQlydW5fdXBkYXRlc2xvdChpYy0+aWNfaWZw KTsKKwkJYnJlYWs7CisJY2FzZSBJRUVFODAyMTFfQkVBQ09OX0hUSU5GTzoK KwkJcnVuX3VwZGF0ZXByb3QoaWMpOworCQlicmVhazsKKwljYXNlIElFRUU4 MDIxMV9CRUFDT05fVElNOgorCQltY2FzdCA9IDE7CS8qVE9ETyovCisJCWJy ZWFrOworCWRlZmF1bHQ6CisJCWJyZWFrOworCX0KKworCXNldGJpdChydnAt PmJvLmJvX2ZsYWdzLCBpdGVtKTsKKwlpZWVlODAyMTFfYmVhY29uX3VwZGF0 ZSh2YXAtPml2X2JzcywgJnJ2cC0+Ym8sIHJ2cC0+YmVhY29uX21idWYsIG1j YXN0KTsKKwogCWkgPSBSVU5fQ01EUV9HRVQoJnNjLT5jbWRxX3N0b3JlKTsK IAlEUFJJTlRGKCJjbWRxX3N0b3JlPSVkXG4iLCBpKTsKIAlzYy0+Y21kcVtp XS5mdW5jID0gcnVuX3VwZGF0ZV9iZWFjb25fY2I7CkBAIC0zOTE2LDE3ICsz OTQxLDI1IEBAIHN0YXRpYyB2b2lkCiBydW5fdXBkYXRlX2JlYWNvbl9jYih2 b2lkICphcmcpCiB7CiAJc3RydWN0IGllZWU4MDIxMXZhcCAqdmFwID0gYXJn OworCXN0cnVjdCBydW5fdmFwICpydnAgPSBSVU5fVkFQKHZhcCk7CiAJc3Ry dWN0IGllZWU4MDIxMWNvbSAqaWMgPSB2YXAtPml2X2ljOwogCXN0cnVjdCBy dW5fc29mdGMgKnNjID0gaWMtPmljX2lmcC0+aWZfc29mdGM7CiAJc3RydWN0 IHJ0Mjg2MF90eHdpIHR4d2k7Ci0Jc3RydWN0IG1idWYgKm07CisJc3RydWN0 IG1idWYgKm0gPSBydnAtPmJlYWNvbl9tYnVmOwogCXVpbnQ4X3QgcmlkeDsK IAogCWlmICh2YXAtPml2X2Jzcy0+bmlfY2hhbiA9PSBJRUVFODAyMTFfQ0hB Tl9BTllDKQogCQlyZXR1cm47CiAKLQlpZiAoKG0gPSBpZWVlODAyMTFfYmVh Y29uX2FsbG9jKHZhcC0+aXZfYnNzLCAmUlVOX1ZBUCh2YXApLT5ibykpID09 IE5VTEwpCi0JICAgICAgICByZXR1cm47CisJLyoKKwkgKiBpZWVlODAyMTFf YmVhY29uX3VwZGF0ZSgpIGlzIGNhbGxlZCBpbiBydW5fdXBkYXRlX2JlYWNv bigpCisJICogJ3J2cC0+YmVhY29uX21idWYgPT0gTlVMTCcgbWVhbnMgbm90 aGluZyB0byB1cGRhdGUgKGNhbGxlZCBmaXJzdCB0aW1lKQorCSAqLworCWlm IChydnAtPmJlYWNvbl9tYnVmID09IE5VTEwpIHsKKwkJaWYgKChydnAtPmJl YWNvbl9tYnVmID0gbSA9CisJCSAgICBpZWVlODAyMTFfYmVhY29uX2FsbG9j KHZhcC0+aXZfYnNzLCAmcnZwLT5ibykpID09IE5VTEwpCisJCQlyZXR1cm47 CisJfQogCiAJbWVtc2V0KCZ0eHdpLCAwLCBzaXplb2YgdHh3aSk7CiAJdHh3 aS53Y2lkID0gMHhmZjsKQEAgLTM5NDEsMTMgKzM5NzQsMTEgQEAgcnVuX3Vw ZGF0ZV9iZWFjb25fY2Iodm9pZCAqYXJnKQogCXR4d2kuZmxhZ3MgPSBSVDI4 NjBfVFhfVFM7CiAJdHh3aS54ZmxhZ3MgPSBSVDI4NjBfVFhfTlNFUTsKIAot CXJ1bl93cml0ZV9yZWdpb25fMShzYywgUlQyODYwX0JDTl9CQVNFKFJVTl9W QVAodmFwKS0+cnZwX2lkKSwKKwlydW5fd3JpdGVfcmVnaW9uXzEoc2MsIFJU Mjg2MF9CQ05fQkFTRShydnAtPnJ2cF9pZCksCiAJICAgICh1aW50OF90ICop JnR4d2ksIHNpemVvZiB0eHdpKTsKLQlydW5fd3JpdGVfcmVnaW9uXzEoc2Ms IFJUMjg2MF9CQ05fQkFTRShSVU5fVkFQKHZhcCktPnJ2cF9pZCkgKyBzaXpl b2YgdHh3aSwKKwlydW5fd3JpdGVfcmVnaW9uXzEoc2MsIFJUMjg2MF9CQ05f QkFTRShydnAtPnJ2cF9pZCkgKyBzaXplb2YgdHh3aSwKIAkgICAgbXRvZCht LCB1aW50OF90ICopLCAobS0+bV9wa3RoZHIubGVuICsgMSkgJiB+MSk7CS8q IHJvdW5kdXAgbGVuICovCiAKLQltX2ZyZWVtKG0pOwotCiAJcmV0dXJuOwog fQogCkBAIC0zOTU1LDYgKzM5ODYsMjAgQEAgc3RhdGljIHZvaWQKIHJ1bl91 cGRhdGVwcm90KHN0cnVjdCBpZWVlODAyMTFjb20gKmljKQogewogCXN0cnVj dCBydW5fc29mdGMgKnNjID0gaWMtPmljX2lmcC0+aWZfc29mdGM7CisJdWlu dDMyX3QgaTsKKworCWkgPSBSVU5fQ01EUV9HRVQoJnNjLT5jbWRxX3N0b3Jl KTsKKwlEUFJJTlRGKCJjbWRxX3N0b3JlPSVkXG4iLCBpKTsKKwlzYy0+Y21k cVtpXS5mdW5jID0gcnVuX3VwZGF0ZXByb3RfY2I7CisJc2MtPmNtZHFbaV0u YXJnMCA9IGljOworCWllZWU4MDIxMV9ydW50YXNrKGljLCAmc2MtPmNtZHFf dGFzayk7Cit9CisKK3N0YXRpYyB2b2lkCitydW5fdXBkYXRlcHJvdF9jYih2 b2lkICphcmcpCit7CisJc3RydWN0IGllZWU4MDIxMWNvbSAqaWMgPSBhcmc7 CisJc3RydWN0IHJ1bl9zb2Z0YyAqc2MgPSBpYy0+aWNfaWZwLT5pZl9zb2Z0 YzsKIAl1aW50MzJfdCB0bXA7CiAKIAl0bXAgPSBSVDI4NjBfUlRTVEhfRU4g fCBSVDI4NjBfUFJPVF9OQVZfU0hPUlQgfCBSVDI4NjBfVFhPUF9BTExPV19B TEw7CkBAIC00MTY0LDEyICs0MjA5LDI5IEBAIHJ1bl9zZXRfbWFjYWRkcihz dHJ1Y3QgcnVuX3NvZnRjICpzYywgY29uc3QgdWludDhfdCAqYWRkcikKIAkg ICAgYWRkcls0XSB8IGFkZHJbNV0gPDwgOCB8IDB4ZmYgPDwgMTYpOwogfQog Ci0vKiBBUkdTVVNFRCAqLwogc3RhdGljIHZvaWQKIHJ1bl91cGRhdGVzbG90 KHN0cnVjdCBpZm5ldCAqaWZwKQogewogCXN0cnVjdCBydW5fc29mdGMgKnNj ID0gaWZwLT5pZl9zb2Z0YzsKIAlzdHJ1Y3QgaWVlZTgwMjExY29tICppYyA9 IGlmcC0+aWZfbDJjb207CisJdWludDMyX3QgaTsKKworCWkgPSBSVU5fQ01E UV9HRVQoJnNjLT5jbWRxX3N0b3JlKTsKKwlEUFJJTlRGKCJjbWRxX3N0b3Jl PSVkXG4iLCBpKTsKKwlzYy0+Y21kcVtpXS5mdW5jID0gcnVuX3VwZGF0ZXNs b3RfY2I7CisJc2MtPmNtZHFbaV0uYXJnMCA9IGlmcDsKKwlpZWVlODAyMTFf cnVudGFzayhpYywgJnNjLT5jbWRxX3Rhc2spOworCisJcmV0dXJuOworfQor CisvKiBBUkdTVVNFRCAqLworc3RhdGljIHZvaWQKK3J1bl91cGRhdGVzbG90 X2NiKHZvaWQgKmFyZykKK3sKKwlzdHJ1Y3QgaWZuZXQgKmlmcCA9IGFyZzsK KwlzdHJ1Y3QgcnVuX3NvZnRjICpzYyA9IGlmcC0+aWZfc29mdGM7CisJc3Ry dWN0IGllZWU4MDIxMWNvbSAqaWMgPSBpZnAtPmlmX2wyY29tOwogCXVpbnQz Ml90IHRtcDsKIAogCXJ1bl9yZWFkKHNjLCBSVDI4NjBfQktPRkZfU0xPVF9D RkcsICZ0bXApOwpAQCAtNDc0Nyw3ICs0ODA5LDcgQEAgcnVuX2luaXRfbG9j a2VkKHN0cnVjdCBydW5fc29mdGMgKnNjKQogCXJ1bl9zZXRfY2hhbihzYywg aWMtPmljX2N1cmNoYW4pOwogCiAJLyogc2V0dXAgaW5pdGlhbCBwcm90ZWN0 aW9uIG1vZGUgKi8KLQlydW5fdXBkYXRlcHJvdChpYyk7CisJcnVuX3VwZGF0 ZXByb3RfY2IoaWMpOwogCiAJLyogdHVybiByYWRpbyBMRUQgb24gKi8KIAly dW5fc2V0X2xlZHMoc2MsIFJUMjg2MF9MRURfUkFESU8pOwpkaWZmIC0tZ2l0 IGEvZGV2L3VzYi93bGFuL2lmX3J1bnZhci5oIGIvZGV2L3VzYi93bGFuL2lm X3J1bnZhci5oCmluZGV4IDM5YWRkYmYuLmNjNjViMWYgMTAwNjQ0Ci0tLSBh L2Rldi91c2Ivd2xhbi9pZl9ydW52YXIuaAorKysgYi9kZXYvdXNiL3dsYW4v aWZfcnVudmFyLmgKQEAgLTEyMSw2ICsxMjEsNyBAQCBzdHJ1Y3QgcnVuX2Nt ZHEgewogc3RydWN0IHJ1bl92YXAgewogCXN0cnVjdCBpZWVlODAyMTF2YXAg ICAgICAgICAgICAgdmFwOwogCXN0cnVjdCBpZWVlODAyMTFfYmVhY29uX29m ZnNldHMgYm87CisJc3RydWN0IG1idWYJCQkqYmVhY29uX21idWY7CiAKIAlp bnQgICAgICAgICAgICAgICAgICAgICAgICAgICAgICgqbmV3c3RhdGUpKHN0 cnVjdCBpZWVlODAyMTF2YXAgKiwKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgZW51bSBpZWVlODAyMTFfc3RhdGUsIGlu dCk7Cg== --0-1961750709-1297127910=:17379--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?95679.17379.qm>