Date: Sun, 16 Aug 2015 23:09:32 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 202375] ports-mgmt/portlint: warn about not using option helpers Message-ID: <bug-202375-13@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202375 Bug ID: 202375 Summary: ports-mgmt/portlint: warn about not using option helpers Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Keywords: feature, needs-patch Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: marcus@FreeBSD.org Reporter: jbeich@FreeBSD.org Flags: maintainer-feedback?(marcus@FreeBSD.org) Assignee: marcus@FreeBSD.org To make ports' Makefiles easier to read and review portlint should warn about conditionals that can be eliminated with option helpers. At least for new ports. For example, $ cd net/ocserv $ portlint -C WARN: Makefile: [49]: USES is defined with `+='. Consider using option helper FOO_USES instead. WARN: Makefile: [50]: LIB_DEPENDS is defined with `+='. Consider using option helper FOO_LIB_DEPENDS instead. WARN: Makefile: [52]: CONFIGURE_ARGS is defined with `+='. Consider using option helpers instead: FOO_CONFIGURE_ENABLE, FOO_CONFIGURE_WITH or FOO_CONFIGURE_ON. WARN: Makefile: [68]: PORT_OPTIONS found within *-install target. Consider using target option helper pre-install-FOO-on or post-install-FOO-on instead. WARN: Makefile: [73]: PORT_OPTIONS found within *-install target. Consider using target option helper pre-install-FOO-on or post-install-FOO-on instead. -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-202375-13>