Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 04 Mar 2016 23:59:34 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 207688] graphics/bmeps: Update to 4.2.2
Message-ID:  <bug-207688-13-PgGmVhFw1Y@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-207688-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-207688-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D207688

--- Comment #1 from Raphael Kubo da Costa <rakuco@FreeBSD.org> ---
Hi,

Have you tried building this update on Poudriere? It doesn't start because =
you
reverted the USES=3Djpeg change.

In addition to that:
- Setting CONFIGURE_ARGS does not seem to be necessary.
- The sed call commenting out sz->lsz are wrong. Instead of removing the
assignments, you should fix them (use st->lsz instead).
- The HAVE_DB_H changes in pre-patch does not seem necessary.
- By the way, for this kind of changes, we normally use the post-patch targ=
et.
- It'd be good if you added a comment explaining why you're changing
CONFIGURE_ENV. It took me a while to figure out why you don't need db.h, for
example.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-207688-13-PgGmVhFw1Y>