From owner-cvs-all@FreeBSD.ORG  Fri Jan 14 13:24:32 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id A85BC16A4CE; Fri, 14 Jan 2005 13:24:32 +0000 (GMT)
Received: from VARK.MIT.EDU (VARK.MIT.EDU [18.95.3.179])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 5083843D1F; Fri, 14 Jan 2005 13:24:32 +0000 (GMT)
	(envelope-from das@FreeBSD.ORG)
Received: from VARK.MIT.EDU (localhost [127.0.0.1])
	by VARK.MIT.EDU (8.13.1/8.13.1) with ESMTP id j0EDOYev097754;
	Fri, 14 Jan 2005 08:24:34 -0500 (EST)
	(envelope-from das@FreeBSD.ORG)
Received: (from das@localhost)
	by VARK.MIT.EDU (8.13.1/8.13.1/Submit) id j0EDOXaf097753;
	Fri, 14 Jan 2005 08:24:33 -0500 (EST)
	(envelope-from das@FreeBSD.ORG)
Date: Fri, 14 Jan 2005 08:24:33 -0500
From: David Schultz <das@FreeBSD.ORG>
To: Kris Kennaway <kris@obsecurity.org>
Message-ID: <20050114132433.GA97735@VARK.MIT.EDU>
Mail-Followup-To: Kris Kennaway <kris@obsecurity.org>,
	src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG
References: <200501140709.j0E79NTA046894@repoman.freebsd.org>
	<20050114131536.GA41709@xor.obsecurity.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20050114131536.GA41709@xor.obsecurity.org>
cc: cvs-src@FreeBSD.ORG
cc: src-committers@FreeBSD.ORG
cc: cvs-all@FreeBSD.ORG
Subject: Re: cvs commit: src/lib/msun/alpha fenv.h src/lib/msun/amd64 fenv.h
	src/lib/msun/arm fenv.h src/lib/msun/i387 fenv.h src/lib/msun/ia64
	fenv.h src/lib/msun/powerpc fenv.h src/lib/msun/sparc64 fenv.h
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Jan 2005 13:24:32 -0000

On Fri, Jan 14, 2005, Kris Kennaway wrote:
> On Fri, Jan 14, 2005 at 07:09:23AM +0000, David Schultz wrote:
> > das         2005-01-14 07:09:23 UTC
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     lib/msun/alpha       fenv.h 
> >     lib/msun/amd64       fenv.h 
> >     lib/msun/arm         fenv.h 
> >     lib/msun/i387        fenv.h 
> >     lib/msun/ia64        fenv.h 
> >     lib/msun/powerpc     fenv.h 
> >     lib/msun/sparc64     fenv.h 
> >   Log:
> >   Mark all inline asms that read the floating-point control or status
> >   registers as volatile.  Instructions that *wrote* to FP state were
> >   already marked volatile, but apparently gcc has license to move
> >   non-volatile asms past volatile asms.  This broke amd64's feupdateenv
> >   at -O2 due to a WAR conflict between fnstsw and fldenv there.
> 
> Do you think this is likely to the cause of the build failures
> reported with a number of ports when world is compiled with -O2
> (i.e. does the feupdateenv failure cascade to other commonly-used
> parts of the code)?

No, this would lead to a runtime failure, and I would be surprised
if very many ports use fenv.h anyway.