From owner-freebsd-hackers@FreeBSD.ORG Sun Mar 14 12:29:39 2010 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 14895106566C; Sun, 14 Mar 2010 12:29:39 +0000 (UTC) (envelope-from yanefbsd@gmail.com) Received: from mail-pz0-f196.google.com (mail-pz0-f196.google.com [209.85.222.196]) by mx1.freebsd.org (Postfix) with ESMTP id D65C68FC0C; Sun, 14 Mar 2010 12:29:38 +0000 (UTC) Received: by pzk34 with SMTP id 34so1480765pzk.3 for ; Sun, 14 Mar 2010 05:29:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=8eaftM0zS0uqpnoCJe9oyaHXWNQdoRNMNxS7ov8+ohk=; b=Dh/RjO/5AZiI3MZbu5mCoVfm2PSOJY8RFC6vphCzjhmpGTUIe323JvZX95LIuW2x1Q lZHIbdMKa95wbUpsSDWGfnkEMNVJ4U4E7BVgSo7A7ONmPnCKovuUm4njs79U119i2zEL kl8r5nYl3pKzi7ygI5uSUSWvylc1F66WGXVd4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=QkunEzOrHW29KTIEtTPqr1OHT+voFnkIDTwedEsUCHjg2WbLK+LMaUIYlbt81xKS6C G5xpn9YmJdMywkzkpzrMr194IBnLaYgyvb1bdkgJpWdLMrbo95H2EpfWjSidRUsJ7n03 atrSLoZxjaKhCoUw28DIwdu5Th6RuN71yAH8Q= MIME-Version: 1.0 Received: by 10.142.1.29 with SMTP id 29mr285832wfa.337.1268569778187; Sun, 14 Mar 2010 05:29:38 -0700 (PDT) In-Reply-To: References: <7d6fde3d1003132155t3059a438m80bd50fdf1dbe091@mail.gmail.com> Date: Sun, 14 Mar 2010 04:29:38 -0800 Message-ID: <7d6fde3d1003140529y5c9c7296m7abcfd685aaa792c@mail.gmail.com> From: Garrett Cooper To: Alexander Best Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-hackers@freebsd.org, Doug Barton Subject: Re: [patch] small fix to stop gcc warning for lib/libstand/assert.c X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Mar 2010 12:29:39 -0000 On Sun, Mar 14, 2010 at 4:12 AM, Alexander Best wrote: > Garrett Cooper schrieb am 2010-03-14: >> On Sat, Mar 13, 2010 at 9:24 PM, Doug Barton >> wrote: >> > On 03/13/10 05:52, Alexander Best wrote: >> >> hello, > >> >> this patch fixes the following gcc warning: > >> > For all such issues, please file a PR first so it doesn't get lost. >> > When >> > you get the PR confirmation back, feel free to alert the list to >> > its >> > existence. > >> =A0 =A0Yes, please submit a proper PR for this because it's a code bug; >> FYI, your solution isn't complete though (it's close): > > ah ok. thanks for the hint. just wanted to spare linimon from dealing wit= h > such minor prs. ;) > >> ABORT(3) =A0 =A0 =A0 =A0 =A0 =A0 =A0 FreeBSD Library Functions Manual >> ABORT(3) > >> NAME >> =A0 =A0 =A0abort -- cause abnormal program termination > >> LIBRARY >> =A0 =A0 =A0Standard C Library (libc, -lc) > >> SYNOPSIS >> =A0 =A0 =A0#include > >> =A0 =A0 =A0void >> =A0 =A0 =A0abort(void); > >> =A0 =A0 Please be explicit and add stdlib.h. > > adding stdlib.h isn't going to work since stand.h is used to declare func= tion > prototypes which are also in stdlib.h. adding stdlib.h will cause gcc to > complain about multiple definitions. stand.h e.g. has it's own printf and= some > other stuff. Excellent point -- which means that any and all blanks in libstand could and should be filled in with equivalents in libc, i.e. you need to make sure that abort(3) has a proper function definition in libstand. Cheers, -Garrett