From owner-svn-src-all@freebsd.org Sat Jan 28 13:25:36 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AB913CC43DB; Sat, 28 Jan 2017 13:25:36 +0000 (UTC) (envelope-from julian@freebsd.org) Received: from vps1.elischer.org (vps1.elischer.org [204.109.63.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "vps1.elischer.org", Issuer "CA Cert Signing Authority" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 7BD92D17; Sat, 28 Jan 2017 13:25:36 +0000 (UTC) (envelope-from julian@freebsd.org) Received: from Julian-MBP3.local (ppp121-45-228-247.lns20.per1.internode.on.net [121.45.228.247]) (authenticated bits=0) by vps1.elischer.org (8.15.2/8.15.2) with ESMTPSA id v0SDPOqJ094549 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Sat, 28 Jan 2017 05:25:27 -0800 (PST) (envelope-from julian@freebsd.org) Subject: Re: svn commit: r312871 - stable/11/share/zoneinfo To: "Rodney W. Grimes" References: <201701271525.v0RFPmVq025332@pdx.rh.CN85.dnsmgr.net> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org From: Julian Elischer Message-ID: <722a5ab1-f997-fa44-4f67-91430673622d@freebsd.org> Date: Sat, 28 Jan 2017 21:25:18 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <201701271525.v0RFPmVq025332@pdx.rh.CN85.dnsmgr.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Jan 2017 13:25:36 -0000 Hi Rod, On 27/1/17 11:25 pm, Rodney W. Grimes wrote: >> Author: julian >> Date: Fri Jan 27 09:11:44 2017 >> New Revision: 312871 >> URL: https://svnweb.freebsd.org/changeset/base/312871 >> >> Log: >> MFH: r308671 >> >> When you select make OLDTIMEZONES=1 then you need a few added directories >> to be made or the command fails >> >> Sponsored by: panzura >> >> MFH: r310426 >> >> If you are going to be run individually to make a new timezone set >> then ensure the destination directories exist. >> Especially if you define OLDTIMEZONES because the mtree pass >> doesn't do it for you. > Perhaps it is time to start pre-processing mtree files so this > would no longer be the case? A much bigger question than I can handle at this time.. :-) > >> Sponsored by: Panzura >> >> Modified: >> stable/11/share/zoneinfo/Makefile >> Directory Properties: >> stable/11/ (props changed) >> >> Modified: stable/11/share/zoneinfo/Makefile >> ============================================================================== >> --- stable/11/share/zoneinfo/Makefile Fri Jan 27 09:07:11 2017 (r312870) >> +++ stable/11/share/zoneinfo/Makefile Fri Jan 27 09:11:44 2017 (r312871) >> @@ -67,6 +67,10 @@ TZBUILDSUBDIRS= \ >> Pacific \ >> SystemV >> >> +.if defined(OLDTIMEZONES) >> +TZBUILDSUBDIRS+= US Mexico Chile Canada Brazil >> +.endif >> + >> .if !defined(_SKIP_BUILD) >> all: zoneinfo >> .endif >> @@ -81,6 +85,8 @@ zoneinfo: yearistype ${TDATA} >> >> beforeinstall: install-zoneinfo >> install-zoneinfo: >> + mkdir -p ${DESTDIR}/usr/share/zoneinfo >> + cd ${DESTDIR}/usr/share/zoneinfo; mkdir -p ${TZBUILDSUBDIRS} > This has the failure mode that your current uid and umask, etc are > used in creating the directories. Please add appropriate chown/chmod > commands to reflect what mtree would of done had it done this. This is mostly because it failed when run as an individual operation to update zoninfo files. which would probably be done as root, or someone who wants the files owned by them. You can't write here unless you are root, so I'm not sure what the right thing to do would be. and chown doesn't work if you are not root, so what would you suggest? (what is needed for the offline permissions tool)? should we assume ${DESTDIR}/usr/share exists already? the following might be a very slight improvement, but ... mkdir -p -m 755 ${DESTDIR}/usr/share mkdir -p -m 755 ${DESTDIR}/usr/share/zoneinfo cd ${DESTDIR}/usr/share/zoneinfo; mkdir -p -m 755 ${TZBUILDSUBDIRS} -cd ${DESTDIR}/usr/share/zoneinfo; chown -R ${BINOWN}:${BINGRP} . < would fail if you are not root. >> cd ${TZBUILDDIR} && \ >> find -s * -type f -print -exec ${INSTALL} ${TAG_ARGS} \ >> -o ${BINOWN} -g ${BINGRP} -m ${NOBINMODE} \ >> _______________________________________________ >> svn-src-stable-11@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/svn-src-stable-11 >> To unsubscribe, send any mail to "svn-src-stable-11-unsubscribe@freebsd.org" >>