From owner-svn-src-head@FreeBSD.ORG Mon Jan 24 07:28:27 2011 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A0397106564A; Mon, 24 Jan 2011 07:28:27 +0000 (UTC) (envelope-from lstewart@freebsd.org) Received: from lauren.room52.net (lauren.room52.net [210.50.193.198]) by mx1.freebsd.org (Postfix) with ESMTP id 5AB378FC1E; Mon, 24 Jan 2011 07:28:27 +0000 (UTC) Received: from lstewart.caia.swin.edu.au (lstewart.caia.swin.edu.au [136.186.229.95]) by lauren.room52.net (Postfix) with ESMTPSA id 8FDDD7E88D; Mon, 24 Jan 2011 18:11:48 +1100 (EST) Message-ID: <4D3D2634.4070005@freebsd.org> Date: Mon, 24 Jan 2011 18:11:48 +1100 From: Lawrence Stewart User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.13) Gecko/20101215 Lightning/1.0b2 Thunderbird/3.1.7 MIME-Version: 1.0 To: mdf@FreeBSD.org References: <201101231300.p0ND0PZi055936@svn.freebsd.org> In-Reply-To: X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=0.0 required=5.0 tests=UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on lauren.room52.net Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r217748 - head/sys/netinet/cc X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Jan 2011 07:28:27 -0000 Hi Matthew, On 01/24/11 02:39, mdf@FreeBSD.org wrote: > For sbuf use for a sysctl you can use sbuf_init_for_sysctl() which I assume you mean sbuf_new_for_sysctl() that's in kern/kern_sysctl.c? It would be useful to document this function in sbuf(9) - I wasn't aware of it and didn't find it when I went looking how to do what my patch somewhat hackishly achieves. > will, instead of growing, push the current data out using SYSCTL_OUT > to a wired user buffer. There's a few examples in the vm/ code. This > can sometimes significantly simplify the code since there's no need to > worry about held mutex/rwlock anymore. I need to MFC the work my patch is against at some point... if/when you MFC the sbuf_set_drain() and sbuf_new_for_sysctl() patches, I'll be happy to switch to using sbuf_new_for_sysctl(). I'll wait until the MFC is done though before switching. Cheers, Lawrence