From owner-freebsd-current Thu Oct 23 14:54:26 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id OAA00650 for current-outgoing; Thu, 23 Oct 1997 14:54:26 -0700 (PDT) (envelope-from owner-freebsd-current) Received: from smtp03.primenet.com (smtp03.primenet.com [206.165.5.84]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id OAA00640 for ; Thu, 23 Oct 1997 14:54:24 -0700 (PDT) (envelope-from tlambert@usr05.primenet.com) Received: (from daemon@localhost) by smtp03.primenet.com (8.8.7/8.8.7) id OAA15545; Thu, 23 Oct 1997 14:54:22 -0700 (MST) Received: from usr05.primenet.com(206.165.6.205) via SMTP by smtp03.primenet.com, id smtpd015527; Thu Oct 23 14:54:14 1997 Received: (from tlambert@localhost) by usr05.primenet.com (8.8.5/8.8.5) id OAA08264; Thu, 23 Oct 1997 14:54:00 -0700 (MST) From: Terry Lambert Message-Id: <199710232154.OAA08264@usr05.primenet.com> Subject: Re: nullfs & current UPDATE! To: Tor.Egge@idi.ntnu.no (Tor Egge) Date: Thu, 23 Oct 1997 21:54:00 +0000 (GMT) Cc: Tor.Egge@idi.ntnu.no, roberto@keltia.freenix.fr, current@FreeBSD.ORG In-Reply-To: <199710232012.WAA00277@pat.idi.ntnu.no> from "Tor Egge" at Oct 23, 97 08:12:07 pm X-Mailer: ELM [version 2.4 PL23] Content-Type: text Sender: owner-freebsd-current@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > > An unconditional call to vrecycle (with ap->a_vp as first argument) in > > the end of null_inactive (after VOP_UNLOCK) might be an alternate > > solution with less side effects. That should cause an immediate vrele > > of the underlying vnode where VOP_INACTIVE is called if usecount > > reaches zero. > > I'm currently using the following patch, which seems to work. [ ... ] Let me repeat my objection, this time in laymans terms: If you start filling in the funtion table, your nullfs is not very NULL, now is it? This is *not* the right approach to solving this problem; it's a kludge, and it shouldn't be perpetuated. Also: try deleting the file backing a running application with this new patch and you unconditional vrecycle() call... see what happens? Terry Lambert terry@lambert.org --- Any opinions in this posting are my own and not those of my present or previous employers.