From owner-freebsd-security@FreeBSD.ORG  Tue Dec  1 12:26:55 2009
Return-Path: <owner-freebsd-security@FreeBSD.ORG>
Delivered-To: freebsd-security@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8B85C106568B
	for <freebsd-security@freebsd.org>;
	Tue,  1 Dec 2009 12:26:55 +0000 (UTC) (envelope-from dan@obluda.cz)
Received: from smtp1.kolej.mff.cuni.cz (smtp1.kolej.mff.cuni.cz
	[IPv6:2001:718:1e03:a01::a])
	by mx1.freebsd.org (Postfix) with ESMTP id 1A79E8FC1F
	for <freebsd-security@freebsd.org>;
	Tue,  1 Dec 2009 12:26:54 +0000 (UTC)
X-Envelope-From: dan@obluda.cz
Received: from kgw.obluda.cz (openvpn.ms.mff.cuni.cz [195.113.20.87])
	by smtp1.kolej.mff.cuni.cz (8.14.3/8.14.3) with ESMTP id nB1CQqHB052962
	for <freebsd-security@freebsd.org>; Tue, 1 Dec 2009 13:26:53 +0100 (CET)
	(envelope-from dan@obluda.cz)
Message-ID: <4B150B8C.90402@obluda.cz>
Date: Tue, 01 Dec 2009 13:26:52 +0100
From: Dan Lukes <dan@obluda.cz>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US;
	rv:1.8.1.23) Gecko/20090908 SeaMonkey/1.1.18
MIME-Version: 1.0
To: freebsd-security@freebsd.org
References: <200912010120.nB11Kjm9087476@freefall.freebsd.org>	<ov3Jq1IJ/c8KAXGQ501G8Os9xr8@Ll2tHa60cb+hiG8R4R8/VS21128>	<20091201114845.359731A828F@mailv.nruns.com>
	<4B1503CB.3080405@nruns.com>
In-Reply-To: <4B1503CB.3080405@nruns.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: Upcoming FreeBSD Security Advisory
X-BeenThere: freebsd-security@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Security issues \[members-only posting\]"
	<freebsd-security.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-security>, 
	<mailto:freebsd-security-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-security>
List-Post: <mailto:freebsd-security@freebsd.org>
List-Help: <mailto:freebsd-security-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-security>, 
	<mailto:freebsd-security-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Dec 2009 12:26:55 -0000

Jan Muenther napsal/wrote, On 12/01/09 12:53:
> I'd be greatly surprised if the affected code looked different in 6.x.

True, affected code is same. But unsetenv() "return" 'void' on 6.x, so 
the code can't be patched the same way as in 7.x/8.x/HEAD

We need something like

if (getenv(...) != NULL ) {
	unsetenv(...);
	if (getenv(...) != NULL )
		ABORT - BROKEN ENVIRONMENT
}

					Dan