From owner-cvs-all Mon Apr 9 5:48:26 2001 Delivered-To: cvs-all@freebsd.org Received: from Awfulhak.org (awfulhak.demon.co.uk [194.222.196.252]) by hub.freebsd.org (Postfix) with ESMTP id C229237B423; Mon, 9 Apr 2001 05:48:14 -0700 (PDT) (envelope-from brian@Awfulhak.org) Received: from hak.lan.Awfulhak.org (root@hak.lan.Awfulhak.org [172.16.0.12]) by Awfulhak.org (8.11.3/8.11.3) with ESMTP id f39Cm8U35294; Mon, 9 Apr 2001 13:48:18 +0100 (BST) (envelope-from brian@lan.Awfulhak.org) Received: from hak.lan.Awfulhak.org (brian@localhost [127.0.0.1]) by hak.lan.Awfulhak.org (8.11.3/8.11.3) with ESMTP id f39CltP01981; Mon, 9 Apr 2001 13:47:55 +0100 (BST) (envelope-from brian@hak.lan.Awfulhak.org) Message-Id: <200104091247.f39CltP01981@hak.lan.Awfulhak.org> X-Mailer: exmh version 2.3.1 01/18/2001 with nmh-1.0.4 To: Martin Cracauer Cc: Brian Somers , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, brian@Awfulhak.org Subject: Re: cvs commit: src/bin/sh parser.c In-Reply-To: Message from Martin Cracauer of "Mon, 09 Apr 2001 12:52:40 +0200." <20010409125240.A15655@cons.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 09 Apr 2001 13:47:55 +0100 From: Brian Somers Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Thanks. This should be fixed in parser.c v1.36. > In <200104041011.f34ABhD62212@freefall.freebsd.org>, Brian Somers wrote: > > brian 2001/04/04 03:11:43 PDT > > > > Modified files: > > bin/sh parser.c > > Log: > > A much better (more correct) fix for handling ``!'' characters > > This is broken for pipes in ! constructs. Try this: > > if ! echo bla | wc -c ; then > echo broken > fi > if ! wc -c /etc/hosts ; then > echo broken > fi > > I am available for reviews of sh fixes. > > Martin > -- > %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% > Martin Cracauer http://www.cons.org/cracauer/ > As far as I'm concerned, if something is so complicated that you can't ex- > plain it in 10 seconds, then it's probably not worth knowing anyway -Calvin -- Brian Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message