From owner-svn-src-all@freebsd.org Sun Sep 4 20:03:06 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 529D6B71858; Sun, 4 Sep 2016 20:03:06 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-it0-f45.google.com (mail-it0-f45.google.com [209.85.214.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 25E49B3D; Sun, 4 Sep 2016 20:03:05 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-it0-f45.google.com with SMTP id e124so119051447ith.0; Sun, 04 Sep 2016 13:03:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=lP2z6S0SJchlQDso0ieY+ysOzATYPINlZ0g9NaZHYwA=; b=biHgSKCuF658WavkaS8UQzI21K7YEOuP5t+9NAvFNNR6negcmgmRAXVxE6ABOxcXKS ZKKh69gJdGBga34nOQZEewoisgRha7PUFHTAiywS7tsOHEyUCjWRqsVg0GkJsObxmHZG ueuv/ZwBlOzTZmsj8ZVkNlHOoYrqy4Wezc95hwZaiK9hrXF3JsY295PFDQLA2/sXDk6m xxYQpzCZEYvcPRUzZ91cOqHajZ0xXkgUqcM+5BZX6wKoEiyj96DTnconWmaTN0TzSvgq uO6/RzsHKglSVUvmaLWUCGFkJfsIpnpl8sEC+a0wjaRH7yueIXNImDPlT1HH4nYPTaVJ twew== X-Gm-Message-State: AE9vXwOy1N0i4XLRPjVzfYaKoJ/BvOVAO8uhiJVRywFZZeYO8bCIfFCERRUhtf5yhxMoWw== X-Received: by 10.36.57.215 with SMTP id l206mr19735837ita.5.1473019384639; Sun, 04 Sep 2016 13:03:04 -0700 (PDT) Received: from mail-it0-f50.google.com (mail-it0-f50.google.com. [209.85.214.50]) by smtp.gmail.com with ESMTPSA id f2sm4465604ite.20.2016.09.04.13.03.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 04 Sep 2016 13:03:04 -0700 (PDT) Received: by mail-it0-f50.google.com with SMTP id i184so119175504itf.1; Sun, 04 Sep 2016 13:03:04 -0700 (PDT) X-Received: by 10.36.189.68 with SMTP id x65mr17345010ite.97.1473019384143; Sun, 04 Sep 2016 13:03:04 -0700 (PDT) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.36.220.129 with HTTP; Sun, 4 Sep 2016 13:03:03 -0700 (PDT) In-Reply-To: References: <201609041755.u84HtMa5060050@repo.freebsd.org> From: Conrad Meyer Date: Sun, 4 Sep 2016 13:03:03 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r305392 - head/sys/conf To: Dimitry Andric Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Sep 2016 20:03:06 -0000 Assuming we'd like to enable building with both compilers for now, isn't it better to use a form both accept? Best, Conrad On Sun, Sep 4, 2016 at 12:31 PM, Dimitry Andric wrote: > On 04 Sep 2016, at 20:57, Conrad Meyer wrote: >> >> On Sun, Sep 4, 2016 at 10:55 AM, Dimitry Andric wrote: >>> Author: dim >>> Date: Sun Sep 4 17:55:22 2016 >>> New Revision: 305392 >>> URL: https://svnweb.freebsd.org/changeset/base/305392 >>> >>> Log: >>> For kernel builds, instead of suppressing certain clang warnings, make >>> them non-fatal, so there is some incentive to fix them eventually. >>> >>> Modified: >>> head/sys/conf/kern.mk >>> >>> Modified: head/sys/conf/kern.mk >>> ============================================================================== >>> --- head/sys/conf/kern.mk Sun Sep 4 17:50:23 2016 (r305391) >>> +++ head/sys/conf/kern.mk Sun Sep 4 17:55:22 2016 (r305392) >>> @@ -17,13 +17,13 @@ CWARNFLAGS?= -Wall -Wredundant-decls -Wn >>> # kernel where fixing them is more trouble than it is worth, or where there is >>> # a false positive. >>> .if ${COMPILER_TYPE} == "clang" >>> -NO_WCONSTANT_CONVERSION= -Wno-constant-conversion >>> -NO_WSHIFT_COUNT_NEGATIVE= -Wno-shift-count-negative >>> -NO_WSHIFT_COUNT_OVERFLOW= -Wno-shift-count-overflow >>> -NO_WSELF_ASSIGN= -Wno-self-assign >>> -NO_WUNNEEDED_INTERNAL_DECL= -Wno-unneeded-internal-declaration >>> +NO_WCONSTANT_CONVERSION= -Wno-error-constant-conversion >>> +NO_WSHIFT_COUNT_NEGATIVE= -Wno-error-shift-count-negative >>> +NO_WSHIFT_COUNT_OVERFLOW= -Wno-error-shift-count-overflow >>> +NO_WSELF_ASSIGN= -Wno-error-self-assign >>> +NO_WUNNEEDED_INTERNAL_DECL= -Wno-error-unneeded-internal-declaration >>> NO_WSOMETIMES_UNINITIALIZED= -Wno-error-sometimes-uninitialized >>> -NO_WCAST_QUAL= -Wno-cast-qual >>> +NO_WCAST_QUAL= -Wno-error-cast-qual >> >> I like goal of the change. Shouldn't these be -Wno-error=cast-qual, >> etc., though? > > That's how gcc spells them. Clang accepts both forms, there is no > functional difference. > > -Dimitry >