From owner-svn-src-all@freebsd.org Sat Sep 14 04:11:05 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9DCAEDDB94; Sat, 14 Sep 2019 04:11:05 +0000 (UTC) (envelope-from peter@rulingia.com) Received: from vtr.rulingia.com (vtr.rulingia.com [IPv6:2001:19f0:5801:ebe:5400:1ff:fe53:30fd]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "vtr.rulingia.com", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46VfFN1YCwz4SZ9; Sat, 14 Sep 2019 04:11:03 +0000 (UTC) (envelope-from peter@rulingia.com) Received: from server.rulingia.com (ppp239-208.static.internode.on.net [59.167.239.208]) by vtr.rulingia.com (8.15.2/8.15.2) with ESMTPS id x8E4Alv8073700 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 14 Sep 2019 14:10:53 +1000 (AEST) (envelope-from peter@rulingia.com) X-Bogosity: Ham, spamicity=0.000000 Received: from server.rulingia.com (localhost.rulingia.com [127.0.0.1]) by server.rulingia.com (8.15.2/8.15.2) with ESMTPS id x8E4Afha009643 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 14 Sep 2019 14:10:41 +1000 (AEST) (envelope-from peter@server.rulingia.com) Received: (from peter@localhost) by server.rulingia.com (8.15.2/8.15.2/Submit) id x8E4AfIo009642; Sat, 14 Sep 2019 14:10:41 +1000 (AEST) (envelope-from peter) Date: Sat, 14 Sep 2019 14:10:41 +1000 From: Peter Jeremy To: Baptiste Daroussin Cc: Charlie Li , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r352275 - in head/lib/libedit: . TEST edit readline Message-ID: <20190914041041.GA97181@server.rulingia.com> References: <201909130650.x8D6o2fb037276@repo.freebsd.org> <6fadeb6b-fe09-f3c7-9bca-b5637bbb4e43@vishwin.info> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lrZ03NoBR/3+SXJZ" Content-Disposition: inline In-Reply-To: <6fadeb6b-fe09-f3c7-9bca-b5637bbb4e43@vishwin.info> X-PGP-Key: http://www.rulingia.com/keys/peter.pgp User-Agent: Mutt/1.12.1 (2019-06-15) X-Rspamd-Queue-Id: 46VfFN1YCwz4SZ9 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of peter@rulingia.com designates 2001:19f0:5801:ebe:5400:1ff:fe53:30fd as permitted sender) smtp.mailfrom=peter@rulingia.com X-Spamd-Result: default: False [-4.07 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; IP_SCORE(-1.17)[ipnet: 2001:19f0:5800::/38(-4.94), asn: 20473(-0.88), country: US(-0.05)]; TAGGED_RCPT(0.00)[freebsd]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; DMARC_NA(0.00)[rulingia.com]; RCPT_COUNT_FIVE(0.00)[5]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; SIGNED_PGP(-2.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:20473, ipnet:2001:19f0:5800::/38, country:US]; RCVD_TLS_ALL(0.00)[]; SUSPICIOUS_RECIPS(1.50)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Sep 2019 04:11:05 -0000 --lrZ03NoBR/3+SXJZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2019-Sep-13 16:33:15 -0400, Charlie Li wrote: >Baptiste Daroussin wrote: >> Author: bapt >> Date: Fri Sep 13 06:50:02 2019 >> New Revision: 352275 >> URL: https://svnweb.freebsd.org/changeset/base/352275 >>=20 >> Log: >> Update libedit to a snapshot from 2019-09-10 >> Reviewed by: Yuichiro Naito >> MFC after: 3 weeks >> Differential Revision: https://reviews.freebsd.org/D21584 >>=20 >I posted in phab but repeating here, this breaks the build on (at least) >aarch64: It breaks the build on arm and arm64 only. wint_t is int on all platforms: sys/sys/_types.h: typedef int __ct_rune_t; /* arg type for ctype funcs */ typedef __ct_rune_t __wint_t; /* wint_t (see above) */ but wchar_t varies between unsigned and signed: $ grep '__wchar_t' sys/*/include/_types.h=20 sys/arm/include/_types.h:typedef unsigned int ___wchar_t; sys/arm64/include/_types.h:typedef unsigned int ___wchar_t; sys/mips/include/_types.h:typedef int ___wchar_t; sys/powerpc/include/_types.h:typedef int ___wchar_t; sys/riscv/include/_types.h:typedef int ___wchar_t; sys/sparc64/include/_types.h:typedef int ___wchar_t; sys/x86/include/_types.h:typedef int ___wchar_t; Looking back into history, it looks like the "unsigned" is part of the ARM EABI. --=20 Peter Jeremy --lrZ03NoBR/3+SXJZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEE7rKYbDBnHnTmXCJ+FqWXoOSiCzQFAl18aDxfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEVF QjI5ODZDMzA2NzFFNzRFNjVDMjI3RTE2QTU5N0EwRTRBMjBCMzQACgkQFqWXoOSi CzR7QQ//bWl+20ZdrNeDeUay1ykf8r84EmNckAIy4TEsZ8gmv6I3QuUDMwCOr8fC 132d4sFAxysXGpIln713DzZa5VCA42J2ahVjsj8LvCp/76CCsLXtcABCC5RRVoUC +akjl+ya35HvtWJyhXD3f5Vn94ULh4vqWjceb6Uqq22/ZiEJ1FA9tLAE7J/luqyK qW1o5Eomw4HJ3GkUIkpCXJq2ECTByEq3AeLo79xox75L5pwEGbFHuy00WS1KfzlC iwEB7Zo72k6ts6VQeUmnHdsTCTpqx3zwHL8oxQ11kLWZf3qn/eZdvW6ZU/BXoYCu VFOfPzmoV0/51VCukNwETNiqI9o9f7i13UZmH8CEN109UTfLPlo/OYKWO3qmnzE4 CdwEB3HOeqnmUjws/JyVKcUNORh3Dn3mvKxRcKyJkiv7LvQuksPxBD+gXjj6F26u HTsg3tgXdAjB9AlIhSgTslMDc+W7AMPi5DyGQyB+WwTDe3h3MDmuZ6ubkT2d0a4S HGHNq4YwI40OX3DvcYdx/O8fvWRrAJUvpLLqdieUK2Ajb5PTHA1aWarzfkMGkqpM i18o0DfsUgYxTCSb2Y6lG8bEV0LTf78Is8G74AH8G6bsuQVCcseE6otXqyTXVKS2 qyE6FFeSClXsamDODLdJgRHi3jxIMWD/wTdDqqrTg2d/6lCykjA= =k6ZD -----END PGP SIGNATURE----- --lrZ03NoBR/3+SXJZ--