From owner-svn-src-projects@freebsd.org Tue Jun 30 16:02:50 2020 Return-Path: Delivered-To: svn-src-projects@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 39E9334F46A for ; Tue, 30 Jun 2020 16:02:50 +0000 (UTC) (envelope-from bjkfbsd@gmail.com) Received: from mail-oi1-x232.google.com (mail-oi1-x232.google.com [IPv6:2607:f8b0:4864:20::232]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49x8Jn6RDjz4bgD; Tue, 30 Jun 2020 16:02:49 +0000 (UTC) (envelope-from bjkfbsd@gmail.com) Received: by mail-oi1-x232.google.com with SMTP id 12so11400646oir.4; Tue, 30 Jun 2020 09:02:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NU20aYJm5ZKUUAcZkpg73NTqD59/ic4aoN755HyaY4E=; b=Dh21RsM6t5OWV6707jixiYs8HSzN1AEVf/KScGN6V7JqFdmUqKdVpdF41w0wnMEUIq 5GrQTiSFL2/IlLvfIH8ElLN+12YLOBEudB5taLtjXCUuFgoUNe/N2ULGv6dGvUS23lCL aE8DjMBhFHXk0kO+vKxDRi0wBKW6e89vYhsTwMcZCGT8O90DpctmgIXlE/rPL2ubA8w8 nGTKzaYJ55gC53IJ5ZtFkOCgqo7jhwDqsWw0f0WYJE2MDjnRI94gwGkamzjM+ci90viJ GFGz8IDJHhXil/dktFSEP6eEVqZWdFwvUmaWAuTJrxHzi0TkAPmmFxOD7TO4nzrugEm4 z2pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NU20aYJm5ZKUUAcZkpg73NTqD59/ic4aoN755HyaY4E=; b=Um1CACE9nYWmbx7rF6IZbi0x4xN91uTW688alZnHwFkDEldbnbl/ylLLyovwMlvZtw rWysy8dj01gblUxkxsiyhb8DzvOk3YGHrqcrrkpNC+TUcr1ID7bsqGAHo2RHakfSbkFj uY5rRsVzyBRxPyeErveSXFKoKRceVyipWmXJPypKQVEXMD1PnxIz+ZNgYQRmlQSzcMjW m3TwT+1gFIInwJDyRKgZm8KA7PC6neM1AWoH8X0IGiF7Oo0qrxN0qkYw+NnHapb1kRxB DzbmQ5JGIF/ZtDpSnd7HV9hVqRPwMOkYBBnZBwzDv5X5u2wZc7NZTISG1YLwTZ9zIeKs LgFA== X-Gm-Message-State: AOAM5339p7CurVSvguAmc6fTdAbT84tJOR5m6QzDtQPRqSNU47Ak5pRP noOIVKWb03CD4Llh0UUFz+1uIUhKfGJT00qdC44n1g2z X-Google-Smtp-Source: ABdhPJw+nZrS2XsB5ZEcD9kD4pxpaobHMGciyM9kVqaIykFZZwoIvUNpIOrD/lDkDV5cxEvWebNOZrQNekdU4zeEiKg= X-Received: by 2002:aca:f087:: with SMTP id o129mr15401319oih.47.1593532968564; Tue, 30 Jun 2020 09:02:48 -0700 (PDT) MIME-Version: 1.0 References: <202006301449.05UEnq2x072917@repo.freebsd.org> In-Reply-To: <202006301449.05UEnq2x072917@repo.freebsd.org> From: Benjamin Kaduk Date: Tue, 30 Jun 2020 09:02:37 -0700 Message-ID: Subject: Re: svn commit: r362798 - in projects/nfs-over-tls/sys/rpc: . rpcsec_tls To: Rick Macklem Cc: src-committers , svn-src-projects@freebsd.org X-Rspamd-Queue-Id: 49x8Jn6RDjz4bgD X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Jun 2020 16:02:50 -0000 On Tue, Jun 30, 2020 at 7:49 AM Rick Macklem wrote: > Author: rmacklem > Date: Tue Jun 30 14:49:51 2020 > New Revision: 362798 > URL: https://svnweb.freebsd.org/changeset/base/362798 > > Log: > Testing when a server does not respond to TLS handshake records exposed > a couple of problems, since the daemon would be in SSL_connect() for 6 > minutes. > > - When the upcall timed out and was retried, the RPCTLS_SYSC_CLSOCKET > syscall > was broken and did not return an error upon a retry. It allocated a > file > descriptor for a NULL socket. > - The socket structure in the kernel could be free'd while the daemon was > still using it in SSL_connect(). > - Adjust the timeout a retry count so that upcalls are only attempted > once > with a 10minute timeout. > > 10 minutes seems really long! It sounds from the description like the upcall so that userspace can run SSL_connect() was taking 6 minutes, and you needed 10 minutes so as to be longer than the 6 minutes that is "out of your control"? I feel like there should be some sockopts available to get the SSL_connect() timeout down, so that the upcall timeout doesn't need to be so long, either. -Ben