From owner-freebsd-current Wed Mar 20 14:23:40 1996 Return-Path: owner-current Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id OAA09773 for current-outgoing; Wed, 20 Mar 1996 14:23:40 -0800 (PST) Received: from ki.net (root@ki.net [142.77.249.8]) by freefall.freebsd.org (8.7.3/8.7.3) with ESMTP id OAA09597 for ; Wed, 20 Mar 1996 14:20:43 -0800 (PST) Received: (from scrappy@localhost) by ki.net (8.7.4/8.7.4) id RAA08072; Wed, 20 Mar 1996 17:17:20 -0500 (EST) Date: Wed, 20 Mar 1996 17:17:18 -0500 (EST) From: "Marc G. Fournier" To: JULIAN Elischer cc: current@freebsd.org Subject: Re: PATCH: small, syntax changes for devfs In-Reply-To: <199603202159.NAA17420@ref.tfs.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-current@freebsd.org X-Loop: FreeBSD.org Precedence: bulk On Wed, 20 Mar 1996, JULIAN Elischer wrote: > you can put printf's almost anywhere. > set_ds_labeldevs doesn't make nodes? > I seem to have all the nodes on my systems... > For some reason, I'm getting all my /dev/sd0[abcef] devices, but none of the /dev/sd0s1[abcef] devices. Looking at the code, I can't find any reason for it not to make the devices, which is why I'm going to shove in a few printf's and see what code is not being executed. > > if (slice >= BASE_SLICE && sp->ds_bdev == NULL && sp->ds_size != 0) { > > mynor = minor(dkmodpart(dev, RAW_PART)); > > ! sp->ds_bdev = > > ! devfs_add_devswf(bdevsw, mynor, DV_BLK, 0, 0, 0640, > > ! dsname(dname, unit, slice, RAW_PART, > > ! partname)); > > better to use %s than just the string.. > (what if we want a device with a % in it ? :) > Ah...so always have a "format string" in devfs_add_devswf then? regardless of whether it is truely needed or not? :) Marc G. Fournier | POP Mail Telnet Acct DNS Hosting System | WWW Services Database Services | Knowledge, Administrator | | Information and scrappy@ki.net | WWW: http://www.ki.net | Communications, Inc