From nobody Thu Jan 23 14:38:04 2025 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Yf3T86grRz5l2T2 for ; Thu, 23 Jan 2025 14:38:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Yf3T84bvXz3jGF for ; Thu, 23 Jan 2025 14:38:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737643084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GDl1n22d7V/omieJsxmVzag/iYKLXpB7iETTAp41WQo=; b=Sew6M/KjQUW0dygvwppMRu0Vi67UNnFqGzjIvPK4DXzrR1tgOwu7bCTbfnnxnVqvJ6+baP r/MrHXfmQzVOpLhntX+kb+qCz8eLhj8O3RfICS5EgvDDXu3D8eLtlJyw6sXa6LKm/SNZql SfHoQq7q4LgTR2lzL5rZv7P3Pf5NzDw21+FFvUothUa80sEslgdwwf0iscXriU4+G0bbeE 0n/iynnd01cJrGO7JyEel2w8gtcCbA01E2NcTMF3CFEnX0B97plDwQ4AAqzikenMMLtp4J fA2giEJaK8ITlJbDW3HQaD9rRclRP/3tfubwzkMu+XMqLlfhknN4oMd+iyZNDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737643084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GDl1n22d7V/omieJsxmVzag/iYKLXpB7iETTAp41WQo=; b=S2emuYDv4inPOSsoaadFhsaNo7UxGWHuPh35/87vSJrdbdRd9TNsQKRMgKVfRMv5uSCWId 8Pwzamdu17oKNVaXMmN1Uo5toaWmtIFNdGePBPW3vDsibTB0SpPmXVP5owk0gM0MoBIZri oQaqiNswzuVFP4Ry45XAiwupXmMzdOgPFbk0Sl3zBKJ9YeYS1IcOWZWsuZue2GLeb7iP8w h7lYrvmhw2M2KmNSWdj2hl2BH466H2bDdOYWLL+KjlIPuucz5vyjsGvNGmhd3lJJ0yZOO9 Sd3RNw+m8cRwfN+VxssUyxQblC46NuSiNvGoqmHf7Tli5ykl8zJo8VKVzq9YhA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1737643084; a=rsa-sha256; cv=none; b=YwDVXxRkufgHMU3IFiYgQtjUsoKAICmUUjTO5KwQ8oSk1jtUrfBW8ySA3VBfNg7PQ5pz6y 3e61PvIzQMht31odEWBzoRQlxhO1UwqWHg/BC/uXDH+HKm6s8cnAGQFYu/MknruW5pxBtA kamY+6J3IPhVhyyVbk21u79zg5x4og1cVBVMMiC0vJFyxieV9AVylvrg4VvzKmeBRJpAP8 KnCKVsfpWDtMwh7F9CNikj+mKRyWLUPEhJvclwz01a2i0BA2BUkUU69TsneUBAcj9TzdYb MQ1FJq24BMno+/fYbX/4nLyCP3H9lsKaUePA0v77r1QW9LThIh08OD3yrjrpQw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Yf3T83l8DzkKc for ; Thu, 23 Jan 2025 14:38:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 50NEc4LG072961 for ; Thu, 23 Jan 2025 14:38:04 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 50NEc4cM072958 for net@FreeBSD.org; Thu, 23 Jan 2025 14:38:04 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 284057] vmxnet3/iflib: crash in vmxnet3_isc_txd_credits_update Date: Thu, 23 Jan 2025 14:38:04 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.3-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: markj@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D284057 --- Comment #13 from Mark Johnston --- (In reply to Andriy Gapon from comment #12) I don't quite understand the comment either, but it makes some sense to me = that the sysctl hides the problem: the bug is that vmxnet3_isc_txd_credits_updat= e() can be called multiple times in parallel, from an interrupt handler and from the transmit path. The latter happens when ifmp_ring_enqueue() drains the ring, and this is inhibited when abdicate =3D=3D 0. But, I think concurrent calls to vmxnet3_isc_txd_credits_update() is still possible even with that setting, e.g., from _task_fn_tx(). --=20 You are receiving this mail because: You are the assignee for the bug.=