From owner-svn-src-all@freebsd.org Fri Apr 7 21:43:26 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CE3BDD33233; Fri, 7 Apr 2017 21:43:26 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [96.47.65.170]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id ACF58873; Fri, 7 Apr 2017 21:43:26 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by mail.baldwin.cx (Postfix) with ESMTPSA id 09CE610A7B9; Fri, 7 Apr 2017 17:43:19 -0400 (EDT) From: John Baldwin To: Warner Losh Cc: src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r316622 - head/share/mk Date: Fri, 07 Apr 2017 14:43:10 -0700 Message-ID: <2928110.Pl3rnvTUcV@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.0-STABLE; KDE/4.14.10; amd64; ; ) In-Reply-To: References: <201704072002.v37K21Ux032932@repo.freebsd.org> <3876116.W5eNvcJ1Jh@ralph.baldwin.cx> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Fri, 07 Apr 2017 17:43:19 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Apr 2017 21:43:26 -0000 On Friday, April 07, 2017 02:38:16 PM Warner Losh wrote: > The TARGET_CPUTYPE=mips3 likely should be the default in the build > system. We require mips3 or better ISA for our O32 ABI. Since we > require that, making the user set this always is a friction point that > we should file off. It's not like any other architecture. I'll look at > making that the overridable default if I can find a few minutes > sometime. This one in particular is kind of tricky because clang refuses to compile O32 MIPS if you set -march=mips3 (it works if you use mips2 or if you leave off the '-march' entirely). I had played with trying to cater to this by setting default CPUCFLAGS if CPUTYPE was empty but then ran into the problem that clang would need a different setting from GCC and punted. Also, the way we set CFLAGS for alternate lib builds (lib32, etc.) is kind of hackish. Possibly they should be invoking bsd.cpu.mk with a different TARGET_ARCH to avoid duplicating logic. -- John Baldwin